Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/auxiliary/fuzzers/ftp/ftp_pre_post.rb

Summary

Maintainability
F
3 days
Test Coverage

Method run_host has a Cognitive Complexity of 52 (exceeds 5 allowed). Consider refactoring.
Open

  def run_host(ip)

    startstage = datastore['STARTATSTAGE']

    @nr_errors = datastore['STOPAFTER']
Severity: Minor
Found in modules/auxiliary/fuzzers/ftp/ftp_pre_post.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method process_phase has a Cognitive Complexity of 43 (exceeds 5 allowed). Consider refactoring.
Open

  def process_phase(phase_num, phase_name, prepend = '', initial_cmds = [])
    print_status("[Phase #{phase_num}] #{phase_name} - #{Time.now.localtime}")
    ecount = 1
    @evilchars.each do |evilstr|
Severity: Minor
Found in modules/auxiliary/fuzzers/ftp/ftp_pre_post.rb - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run_host has 90 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def run_host(ip)

    startstage = datastore['STARTATSTAGE']

    @nr_errors = datastore['STOPAFTER']
Severity: Major
Found in modules/auxiliary/fuzzers/ftp/ftp_pre_post.rb - About 3 hrs to fix

    Method process_phase has 56 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def process_phase(phase_num, phase_name, prepend = '', initial_cmds = [])
    print_status("[Phase #{phase_num}] #{phase_name} - #{Time.now.localtime}")
    ecount = 1
    @evilchars.each do |evilstr|
    Severity: Major
    Found in modules/auxiliary/fuzzers/ftp/ftp_pre_post.rb - About 2 hrs to fix

      Method initialize has 45 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def initialize
    super(
      'Name'           => 'Simple FTP Fuzzer',
      'Description'    => %q{
        This module will connect to a FTP server and perform pre- and post-authentication fuzzing
      Severity: Minor
      Found in modules/auxiliary/fuzzers/ftp/ftp_pre_post.rb - About 1 hr to fix

        Avoid deeply nested control flow statements.
        Open

                      if datastore['ExpandCrash']
                print_status("Crash string : #{prepend}#{evil}")
              else
                print_status("Crash string : #{prepend}#{evilstr} x #{count}")
              end
        Severity: Major
        Found in modules/auxiliary/fuzzers/ftp/ftp_pre_post.rb - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                        if (e.class.name == 'Rex::ConnectionRefused') or (e.class.name == 'EOFError') or (e.class.name == 'Errno::ECONNRESET' and datastore['CONNRESET']) or (e.class.name == 'Errno::EPIPE')
                if @error_cnt >= @nr_errors
                  print_status("System does not respond - exiting now\n")
                  @stopprocess = true
                  print_error("Error: #{e.class} #{e} #{e.backtrace}\n")
          Severity: Major
          Found in modules/auxiliary/fuzzers/ftp/ftp_pre_post.rb - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                          if @error_cnt >= @nr_errors
                print_status("System does not respond - exiting now\n")
                @stopprocess = true
                print_error("Error: #{e.class} #{e} #{e.backtrace}\n")
                return
            Severity: Major
            Found in modules/auxiliary/fuzzers/ftp/ftp_pre_post.rb - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                            if @error_cnt >= @nr_errors
                @error_cnt = 0
              end
              Severity: Major
              Found in modules/auxiliary/fuzzers/ftp/ftp_pre_post.rb - About 45 mins to fix

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                              if @error_cnt >= @nr_errors
                print_status("System does not respond - exiting now\n")
                @stopprocess = true
                print_error("Error: #{e.class} #{e} #{e.backtrace}\n")
                return
                Severity: Minor
                Found in modules/auxiliary/fuzzers/ftp/ftp_pre_post.rb and 1 other location - About 35 mins to fix
                modules/auxiliary/fuzzers/ftp/ftp_pre_post.rb on lines 229..236

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 36.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                                if @error_cnt >= @nr_errors
                  print_status("System does not respond - exiting now\n")
                  @stopprocess = true
                  print_error("Error: #{e.class} #{e} #{e.backtrace}\n")
                  return
                Severity: Minor
                Found in modules/auxiliary/fuzzers/ftp/ftp_pre_post.rb and 1 other location - About 35 mins to fix
                modules/auxiliary/fuzzers/ftp/ftp_pre_post.rb on lines 118..125

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 36.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                            if (e.class.name == 'Rex::ConnectionRefused') or (e.class.name == 'EOFError') or (e.class.name == 'Errno::ECONNRESET' and datastore['CONNRESET']) or (e.class.name == 'Errno::EPIPE')
              if datastore['ExpandCrash']
                print_status("Crash string : #{prepend}#{evil}")
              else
                print_status("Crash string : #{prepend}#{evilstr} x #{count}")
                Severity: Minor
                Found in modules/auxiliary/fuzzers/ftp/ftp_pre_post.rb and 1 other location - About 20 mins to fix
                modules/auxiliary/fuzzers/ftp/ftp_pre_post.rb on lines 228..238

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 27.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                              if (e.class.name == 'Rex::ConnectionRefused') or (e.class.name == 'EOFError') or (e.class.name == 'Errno::ECONNRESET' and datastore['CONNRESET']) or (e.class.name == 'Errno::EPIPE')
                if @error_cnt >= @nr_errors
                  print_status("System does not respond - exiting now\n")
                  @stopprocess = true
                  print_error("Error: #{e.class} #{e} #{e.backtrace}\n")
                Severity: Minor
                Found in modules/auxiliary/fuzzers/ftp/ftp_pre_post.rb and 1 other location - About 20 mins to fix
                modules/auxiliary/fuzzers/ftp/ftp_pre_post.rb on lines 112..127

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 27.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status