Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/auxiliary/gather/alienvault_iso27001_sqli.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Method run has 57 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def run

    print_status("Get a valid session cookie...")
    res = send_request_cgi({
      'uri' => normalize_uri(target_uri.path, 'ossim', 'session', 'login.php')
Severity: Major
Found in modules/auxiliary/gather/alienvault_iso27001_sqli.rb - About 2 hrs to fix

    Method run has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

      def run

    print_status("Get a valid session cookie...")
    res = send_request_cgi({
      'uri' => normalize_uri(target_uri.path, 'ossim', 'session', 'login.php')
    Severity: Minor
    Found in modules/auxiliary/gather/alienvault_iso27001_sqli.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method initialize has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize(info={})
    super(update_info(info,
      'Name'           => "AlienVault Authenticated SQL Injection Arbitrary File Read",
      'Description'    => %q{
        AlienVault 4.5.0 is susceptible to an authenticated SQL injection attack via a PNG
    Severity: Minor
    Found in modules/auxiliary/gather/alienvault_iso27001_sqli.rb - About 1 hr to fix

      Method sqli has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        def sqli(left_marker, right_marker, i, cookie, filename)
      Severity: Minor
      Found in modules/auxiliary/gather/alienvault_iso27001_sqli.rb - About 35 mins to fix

        Avoid too many return statements within this method.
        Open

              return if file.nil?
        Severity: Major
        Found in modules/auxiliary/gather/alienvault_iso27001_sqli.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                return
          Severity: Major
          Found in modules/auxiliary/gather/alienvault_iso27001_sqli.rb - About 30 mins to fix

            There are no issues that match your filters.

            Category
            Status