Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/auxiliary/gather/cloud_lookup.rb

Summary

Maintainability
F
5 days
Test Coverage

File cloud_lookup.rb has 580 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'public_suffix'

class MetasploitModule < Msf::Auxiliary
  include Msf::Exploit::Remote::DNS::Enumeration
  include Msf::Auxiliary::Report
Severity: Major
Found in modules/auxiliary/gather/cloud_lookup.rb - About 1 day to fix

    Method run has a Cognitive Complexity of 49 (exceeds 5 allowed). Consider refactoring.
    Open

      def run
    # If the action can be detected automatically. (Action: Automatic)
    @my_action = pick_action
    if @my_action.nil?
      # If the automatic search fails, bye bye.
    Severity: Minor
    Found in modules/auxiliary/gather/cloud_lookup.rb - About 7 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method initialize has 140 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'Cloud Lookup (and Bypass)',
    Severity: Major
    Found in modules/auxiliary/gather/cloud_lookup.rb - About 5 hrs to fix

      Method check_request has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
      Open

        def check_request(fingerprint, ip, port, ssl)
    proto = (ssl ? 'https' : 'http')

    vprint_status(" * Trying: #{proto}://#{ip}:#{port}/")
    response = http_get_request_raw(ip, port, ssl, datastore['URIPATH'], datastore['HOSTNAME'])
      Severity: Minor
      Found in modules/auxiliary/gather/cloud_lookup.rb - About 5 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method run has 134 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def run
    # If the action can be detected automatically. (Action: Automatic)
    @my_action = pick_action
    if @my_action.nil?
      # If the automatic search fails, bye bye.
      Severity: Major
      Found in modules/auxiliary/gather/cloud_lookup.rb - About 5 hrs to fix

        Method check_request has 39 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def check_request(fingerprint, ip, port, ssl)
    proto = (ssl ? 'https' : 'http')

    vprint_status(" * Trying: #{proto}://#{ip}:#{port}/")
    response = http_get_request_raw(ip, port, ssl, datastore['URIPATH'], datastore['HOSTNAME'])
        Severity: Minor
        Found in modules/auxiliary/gather/cloud_lookup.rb - About 1 hr to fix

          Method grab_domain_ip_history has 35 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def grab_domain_ip_history(domain)
    begin
      cli = Rex::Proto::Http::Client.new('viewdns.info', 443, {}, true, nil, datastore['Proxies'])
      cli.connect
          Severity: Minor
          Found in modules/auxiliary/gather/cloud_lookup.rb - About 1 hr to fix

            Method azurecdn_ips has 33 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              def azurecdn_ips
    regions = {
      'region' => [
        'asiaeast', 'asiasoutheast', 'australiaeast', 'australiasoutheast', 'canadacentral',
        'canadaeast', 'chinaeast', 'chinanorth', 'europenorth', 'europewest',
            Severity: Minor
            Found in modules/auxiliary/gather/cloud_lookup.rb - About 1 hr to fix

              Method grab_domain_ip_history has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

                def grab_domain_ip_history(domain)
    begin
      cli = Rex::Proto::Http::Client.new('viewdns.info', 443, {}, true, nil, datastore['Proxies'])
      cli.connect
              Severity: Minor
              Found in modules/auxiliary/gather/cloud_lookup.rb - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method pick_action has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                def pick_action
    return action if action.name != 'Automatic'

    response = http_get_request_raw(
      datastore['HOSTNAME'],
              Severity: Minor
              Found in modules/auxiliary/gather/cloud_lookup.rb - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Avoid deeply nested control flow statements.
              Open

                        save_note(datastore['HOSTNAME'], ip, port, proto, false) if datastore['REPORT_LEAKS']
              Severity: Major
              Found in modules/auxiliary/gather/cloud_lookup.rb - About 45 mins to fix

                Method save_note has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                  def save_note(hostname, ip, port, proto, ebypass)
                Severity: Minor
                Found in modules/auxiliary/gather/cloud_lookup.rb - About 35 mins to fix

                  Method http_get_request_raw has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                    def http_get_request_raw(host, port, ssl, uri, vhost = nil)
                  Severity: Minor
                  Found in modules/auxiliary/gather/cloud_lookup.rb - About 35 mins to fix

                    Avoid too many return statements within this method.
                    Open

                        return false
                    Severity: Major
                    Found in modules/auxiliary/gather/cloud_lookup.rb - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                              return
                      Severity: Major
                      Found in modules/auxiliary/gather/cloud_lookup.rb - About 30 mins to fix

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                              ip_records = dns_bruteforce(domain_name, datastore['WORDLIST'], datastore['THREADS'])
      if ip_records && !ip_records.empty?
        ip_list |= ip_records
      end
      print_status(" * DNS Enumeration: #{ip_records.count} IP address(es) found.")
                        Severity: Minor
                        Found in modules/auxiliary/gather/cloud_lookup.rb and 1 other location - About 15 mins to fix
                        modules/auxiliary/gather/cloud_lookup.rb on lines 580..584

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 26.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                              ip_records = censys_search(domain_name, datastore['CENSYS_UID'], datastore['CENSYS_SECRET'])
      if ip_records && !ip_records.empty?
        ip_list |= ip_records
      end
      print_status(" * Censys IPv4: #{ip_records.count} IP address(es) found.")
                        Severity: Minor
                        Found in modules/auxiliary/gather/cloud_lookup.rb and 1 other location - About 15 mins to fix
                        modules/auxiliary/gather/cloud_lookup.rb on lines 571..575

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 26.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        There are no issues that match your filters.

                        Category
                        Status