rapid7/metasploit-framework

View on GitHub
modules/auxiliary/gather/corpwatch_lookup_id.rb

Summary

Maintainability
F
5 days
Test Coverage

Method run has 401 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def run

    loot = ""
    uri = "/"
    uri << (datastore['YEAR']).to_s if datastore['YEAR'].to_s != ""
Severity: Major
Found in modules/auxiliary/gather/corpwatch_lookup_id.rb - About 2 days to fix

    Method run has a Cognitive Complexity of 79 (exceeds 5 allowed). Consider refactoring.
    Open

      def run
    
        loot = ""
        uri = "/"
        uri << (datastore['YEAR']).to_s if datastore['YEAR'].to_s != ""
    Severity: Minor
    Found in modules/auxiliary/gather/corpwatch_lookup_id.rb - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File corpwatch_lookup_id.rb has 445 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require 'rexml/document'
    
    class MetasploitModule < Msf::Auxiliary
      include Msf::Exploit::Remote::HttpClient
    
    
    Severity: Minor
    Found in modules/auxiliary/gather/corpwatch_lookup_id.rb - About 6 hrs to fix

      Avoid too many return statements within this method.
      Open

            return
      Severity: Major
      Found in modules/auxiliary/gather/corpwatch_lookup_id.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                return
        Severity: Major
        Found in modules/auxiliary/gather/corpwatch_lookup_id.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                  return
          Severity: Major
          Found in modules/auxiliary/gather/corpwatch_lookup_id.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                    return
            Severity: Major
            Found in modules/auxiliary/gather/corpwatch_lookup_id.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                      return
              Severity: Major
              Found in modules/auxiliary/gather/corpwatch_lookup_id.rb - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                        return
                Severity: Major
                Found in modules/auxiliary/gather/corpwatch_lookup_id.rb - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                          return
                  Severity: Major
                  Found in modules/auxiliary/gather/corpwatch_lookup_id.rb - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                            return
                    Severity: Major
                    Found in modules/auxiliary/gather/corpwatch_lookup_id.rb - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                            return
                      Severity: Major
                      Found in modules/auxiliary/gather/corpwatch_lookup_id.rb - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                  return
                        Severity: Major
                        Found in modules/auxiliary/gather/corpwatch_lookup_id.rb - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                  return
                          Severity: Major
                          Found in modules/auxiliary/gather/corpwatch_lookup_id.rb - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                    return
                            Severity: Major
                            Found in modules/auxiliary/gather/corpwatch_lookup_id.rb - About 30 mins to fix

                              Avoid too many return statements within this method.
                              Open

                                      return
                              Severity: Major
                              Found in modules/auxiliary/gather/corpwatch_lookup_id.rb - About 30 mins to fix

                                Avoid too many return statements within this method.
                                Open

                                        return
                                Severity: Major
                                Found in modules/auxiliary/gather/corpwatch_lookup_id.rb - About 30 mins to fix

                                  Avoid too many return statements within this method.
                                  Open

                                          return
                                  Severity: Major
                                  Found in modules/auxiliary/gather/corpwatch_lookup_id.rb - About 30 mins to fix

                                    Avoid too many return statements within this method.
                                    Open

                                          return
                                    Severity: Major
                                    Found in modules/auxiliary/gather/corpwatch_lookup_id.rb - About 30 mins to fix

                                      Avoid too many return statements within this method.
                                      Open

                                              return
                                      Severity: Major
                                      Found in modules/auxiliary/gather/corpwatch_lookup_id.rb - About 30 mins to fix

                                        Avoid too many return statements within this method.
                                        Open

                                                return
                                        Severity: Major
                                        Found in modules/auxiliary/gather/corpwatch_lookup_id.rb - About 30 mins to fix

                                          Avoid too many return statements within this method.
                                          Open

                                                  return
                                          Severity: Major
                                          Found in modules/auxiliary/gather/corpwatch_lookup_id.rb - About 30 mins to fix

                                            Identical blocks of code found in 2 locations. Consider refactoring.
                                            Open

                                              def grab_text(e, name)
                                                (e.get_elements(name) && e.get_elements(name)[0] &&
                                                e.get_elements(name)[0].get_text ) ?
                                                e.get_elements(name)[0].get_text.to_s : ""
                                              end
                                            Severity: Minor
                                            Found in modules/auxiliary/gather/corpwatch_lookup_id.rb and 1 other location - About 20 mins to fix
                                            modules/auxiliary/gather/corpwatch_lookup_name.rb on lines 127..131

                                            Duplicated Code

                                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                            Tuning

                                            This issue has a mass of 27.

                                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                            Refactorings

                                            Further Reading

                                            There are no issues that match your filters.

                                            Category
                                            Status