Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/auxiliary/gather/crushftp_fileread_cve_2024_4040.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Method initialize has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'CrushFTP Unauthenticated Arbitrary File Read',
Severity: Minor
Found in modules/auxiliary/gather/crushftp_fileread_cve_2024_4040.rb - About 1 hr to fix

    Method perform_template_injection has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def perform_template_injection(page, payload, cookie)
    if page == 'zip'
      send_request_cgi(
        {
          'method' => 'POST',
    Severity: Minor
    Found in modules/auxiliary/gather/crushftp_fileread_cve_2024_4040.rb - About 1 hr to fix

      Method run has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

        def run
    # Unauthenticated requests to WebInterface endpoints should receive a response containing an 'anonymous' user session cookie
    print_status('Fetching anonymous session cookie...')
    res_anonymous = get_anon_session
      Severity: Minor
      Found in modules/auxiliary/gather/crushftp_fileread_cve_2024_4040.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method run has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def run
    # Unauthenticated requests to WebInterface endpoints should receive a response containing an 'anonymous' user session cookie
    print_status('Fetching anonymous session cookie...')
    res_anonymous = get_anon_session
      Severity: Minor
      Found in modules/auxiliary/gather/crushftp_fileread_cve_2024_4040.rb - About 1 hr to fix

        Method check has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

          def check
    # Unauthenticated requests to WebInterface endpoints should receive a response containing an 'anonymous' user session cookie
    res_anonymous_check = get_anon_session

    return Msf::Exploit::CheckCode::Unknown('Connection failed - unable to get 404 page response (confirm target and SSL settings)') unless res_anonymous_check
        Severity: Minor
        Found in modules/auxiliary/gather/crushftp_fileread_cve_2024_4040.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status