Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/auxiliary/gather/f5_bigip_cookie_disclosure.rb

Summary

Maintainability
C
1 day
Test Coverage

Method run has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
Open

  def run
    requests = datastore['REQUESTS']
    backends = []
    cookie_name = ''
    pool_name = ''
Severity: Minor
Found in modules/auxiliary/gather/f5_bigip_cookie_disclosure.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def run
    requests = datastore['REQUESTS']
    backends = []
    cookie_name = ''
    pool_name = ''
Severity: Minor
Found in modules/auxiliary/gather/f5_bigip_cookie_disclosure.rb - About 1 hr to fix

    Method initialize has 40 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'F5 BIG-IP Backend Cookie Disclosure',
    Severity: Minor
    Found in modules/auxiliary/gather/f5_bigip_cookie_disclosure.rb - About 1 hr to fix

      Method cookie_decode has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def cookie_decode(cookie_value)
    backend = {}
    if cookie_value =~ /(\d{8,10})\.(\d{1,5})\./
      host = Regexp.last_match(1).to_i
      port = Regexp.last_match(2).to_i
      Severity: Minor
      Found in modules/auxiliary/gather/f5_bigip_cookie_disclosure.rb - About 1 hr to fix

        Method cookie_decode has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

          def cookie_decode(cookie_value)
    backend = {}
    if cookie_value =~ /(\d{8,10})\.(\d{1,5})\./
      host = Regexp.last_match(1).to_i
      port = Regexp.last_match(2).to_i
        Severity: Minor
        Found in modules/auxiliary/gather/f5_bigip_cookie_disclosure.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method fetch_cookie has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

          def fetch_cookie
    # Request a page and extract a F5 looking cookie
    cookie = {}
    res = send_request_raw('method' => 'GET', 'uri' => @uri)
        Severity: Minor
        Found in modules/auxiliary/gather/f5_bigip_cookie_disclosure.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status