Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/auxiliary/gather/fortios_vpnssl_traversal_creds_leak.rb

Summary

Maintainability
C
1 day
Test Coverage

Method run_host has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

  def run_host(ip)
    @proto = (ssl ? 'https' : 'http')
    @ip_address = ip

    print_status(message('Trying to connect.'))
Severity: Minor
Found in modules/auxiliary/gather/fortios_vpnssl_traversal_creds_leak.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method initialize has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'FortiOS Path Traversal Credential Gatherer',
Severity: Minor
Found in modules/auxiliary/gather/fortios_vpnssl_traversal_creds_leak.rb - About 1 hr to fix

    Method execute_request has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def execute_request
    payload = '/../../../..//////////dev/cmdb/sslvpn_websession'

    uri = normalize_uri(target_uri.path, 'fgt_lang')
    begin
    Severity: Minor
    Found in modules/auxiliary/gather/fortios_vpnssl_traversal_creds_leak.rb - About 1 hr to fix

      Method run_host has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def run_host(ip)
    @proto = (ssl ? 'https' : 'http')
    @ip_address = ip

    print_status(message('Trying to connect.'))
      Severity: Minor
      Found in modules/auxiliary/gather/fortios_vpnssl_traversal_creds_leak.rb - About 1 hr to fix

        Method report_creds has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def report_creds(creds)
    creds.each do |cred|
      cred = cred.gsub('"', '').gsub(/[{}:]/, '').split(', ')
      cred = cred.map do |h|
        h1, h2 = h.split('=>')
        Severity: Minor
        Found in modules/auxiliary/gather/fortios_vpnssl_traversal_creds_leak.rb - About 1 hr to fix

          Method execute_request has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

            def execute_request
    payload = '/../../../..//////////dev/cmdb/sslvpn_websession'

    uri = normalize_uri(target_uri.path, 'fgt_lang')
    begin
          Severity: Minor
          Found in modules/auxiliary/gather/fortios_vpnssl_traversal_creds_leak.rb - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status