Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/auxiliary/gather/hp_snac_domain_creds.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method run has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def run

    print_status("Get Domain Info")
    session = get_session
Severity: Minor
Found in modules/auxiliary/gather/hp_snac_domain_creds.rb - About 1 hr to fix

    Method initialize has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize(info = {})
    super(update_info(info,
      'Name'           => 'HP ProCurve SNAC Domain Controller Credential Dumper',
      'Description'    => %q{
        This module will extract Domain Controller credentials from vulnerable installations of HP
    Severity: Minor
    Found in modules/auxiliary/gather/hp_snac_domain_creds.rb - About 1 hr to fix

      Similar blocks of code found in 32 locations. Consider refactoring.
      Open

        def report_cred(opts)
    service_data = {
      address: opts[:ip],
      port: opts[:port],
      service_name: opts[:service_name],
      Severity: Major
      Found in modules/auxiliary/gather/hp_snac_domain_creds.rb and 31 other locations - About 1 hr to fix
      modules/auxiliary/admin/misc/sercomm_dump_config.rb on lines 88..111
      modules/auxiliary/admin/scada/advantech_webaccess_dbvisitor_sqli.rb on lines 191..214
      modules/auxiliary/gather/apache_rave_creds.rb on lines 107..130
      modules/auxiliary/gather/d20pass.rb on lines 182..205
      modules/auxiliary/gather/doliwamp_traversal_creds.rb on lines 152..175
      modules/auxiliary/gather/windows_deployment_services_shares.rb on lines 196..219
      modules/auxiliary/scanner/couchdb/couchdb_login.rb on lines 76..99
      modules/auxiliary/scanner/dcerpc/windows_deployment_services.rb on lines 214..237
      modules/auxiliary/scanner/http/openmind_messageos_login.rb on lines 72..95
      modules/auxiliary/scanner/http/radware_appdirector_enum.rb on lines 78..101
      modules/auxiliary/scanner/misc/dvr_config_disclosure.rb on lines 147..170
      modules/auxiliary/scanner/misc/dvr_config_disclosure.rb on lines 210..233
      modules/auxiliary/scanner/misc/raysharp_dvr_passwords.rb on lines 36..59
      modules/auxiliary/scanner/misc/rosewill_rxs3211_passwords.rb on lines 84..107
      modules/auxiliary/scanner/openvas/openvas_gsad_login.rb on lines 115..138
      modules/auxiliary/scanner/oracle/isqlplus_login.rb on lines 231..254
      modules/auxiliary/scanner/postgres/postgres_version.rb on lines 51..74
      modules/auxiliary/scanner/rservices/rsh_login.rb on lines 221..244
      modules/auxiliary/scanner/sap/sap_ctc_verb_tampering_user_mgmt.rb on lines 86..109
      modules/auxiliary/scanner/sap/sap_mgmt_con_brute_login.rb on lines 63..86
      modules/auxiliary/scanner/sap/sap_soap_bapi_user_create1.rb on lines 52..75
      modules/auxiliary/scanner/scada/koyo_login.rb on lines 127..150
      modules/auxiliary/server/capture/drda.rb on lines 237..260
      modules/auxiliary/server/capture/ftp.rb on lines 51..74
      modules/auxiliary/server/capture/http.rb on lines 107..130
      modules/auxiliary/server/capture/http_basic.rb on lines 57..80
      modules/auxiliary/server/capture/mysql.rb on lines 127..150
      modules/auxiliary/server/capture/pop3.rb on lines 53..76
      modules/auxiliary/server/capture/postgresql.rb on lines 41..64
      modules/auxiliary/server/capture/sip.rb on lines 105..128
      modules/exploits/linux/http/dlink_dir850l_unauth_exec.rb on lines 69..92

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 57.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 3 locations. Consider refactoring.
      Open

        def get_session
    res = send_request_cgi({ 'uri' => "/RegWeb/html/snac/index.html" })
    session = nil
    if res and res.code == 200
      session = res.get_cookies
      Severity: Minor
      Found in modules/auxiliary/gather/hp_snac_domain_creds.rb and 2 other locations - About 25 mins to fix
      modules/exploits/windows/http/hp_pcm_snac_update_certificates.rb on lines 75..86
      modules/exploits/windows/http/hp_pcm_snac_update_domain.rb on lines 75..86

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 29.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status