Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/auxiliary/gather/http_pdf_authors.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Method extract_authors has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

  def extract_authors(urls)
    print_status "Processing #{urls.size} URLs..."

    authors = []
    max_len = 256
Severity: Minor
Found in modules/auxiliary/gather/http_pdf_authors.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method initialize has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(update_info(info,
      'Name'        => 'Gather PDF Authors',
      'Description' => %q{
        This module downloads PDF documents and extracts the author's
Severity: Minor
Found in modules/auxiliary/gather/http_pdf_authors.rb - About 1 hr to fix

    Avoid too many return statements within this method.
    Open

        return
    Severity: Major
    Found in modules/auxiliary/gather/http_pdf_authors.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

          return
      Severity: Major
      Found in modules/auxiliary/gather/http_pdf_authors.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

            return
        Severity: Major
        Found in modules/auxiliary/gather/http_pdf_authors.rb - About 30 mins to fix

          Method run has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            def run
    urls = load_urls

    if datastore['URL_TYPE'].eql? 'html'
      urls = extract_pdf_links urls
          Severity: Minor
          Found in modules/auxiliary/gather/http_pdf_authors.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method extract_pdf_links has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            def extract_pdf_links(urls)
    print_status "Processing #{urls.size} URLs..."

    pdf_urls = []
    urls.each_with_index do |url, index|
          Severity: Minor
          Found in modules/auxiliary/gather/http_pdf_authors.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status