Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/auxiliary/gather/ie_sandbox_findfiles.rb

Summary

Maintainability
D
2 days
Test Coverage

File ie_sandbox_findfiles.rb has 334 lines of code (exceeds 250 allowed). Consider refactoring.
Open

class MetasploitModule < Msf::Auxiliary
  include Msf::Exploit::Remote::HttpServer::HTML

  def initialize(info={})
    super(update_info(info,
Severity: Minor
Found in modules/auxiliary/gather/ie_sandbox_findfiles.rb - About 4 hrs to fix

    Method process_propfind has 98 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def process_propfind(cli, request)
    path = request.uri
    print_status("PROPFIND #{path}")
    body = ''
    Severity: Major
    Found in modules/auxiliary/gather/ie_sandbox_findfiles.rb - About 3 hrs to fix

      Method on_request_uri has 54 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def on_request_uri(cli, request)
    my_host  = (datastore['SRVHOST'] == '0.0.0.0') ? Rex::Socket.source_address(cli.peerhost) : datastore['SRVHOST']

    case request.method
    when 'OPTIONS'
      Severity: Major
      Found in modules/auxiliary/gather/ie_sandbox_findfiles.rb - About 2 hrs to fix

        Method generate_files has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def generate_files(path)
    trail = path.split("/")
    return "" if trail.length < 2

    %Q|
        Severity: Minor
        Found in modules/auxiliary/gather/ie_sandbox_findfiles.rb - About 1 hr to fix

          Method initialize has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def initialize(info={})
    super(update_info(info,
      'Name'           => 'Internet Explorer Iframe Sandbox File Name Disclosure Vulnerability',
      'Description'    => %q{
        It was found that Internet Explorer allows the disclosure of local file names.
          Severity: Minor
          Found in modules/auxiliary/gather/ie_sandbox_findfiles.rb - About 1 hr to fix

            Method process_propfind has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

              def process_propfind(cli, request)
    path = request.uri
    print_status("PROPFIND #{path}")
    body = ''
            Severity: Minor
            Found in modules/auxiliary/gather/ie_sandbox_findfiles.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method generate_shares has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              def generate_shares(path)
    share_name = datastore['SHARENAME']
%Q|
<D:response xmlns:lp1="DAV:" xmlns:lp2="http://apache.org/dav/props/">
<D:href>#{path}#{share_name}/</D:href>
            Severity: Minor
            Found in modules/auxiliary/gather/ie_sandbox_findfiles.rb - About 1 hr to fix

              Method on_request_uri has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                def on_request_uri(cli, request)
    my_host  = (datastore['SRVHOST'] == '0.0.0.0') ? Rex::Socket.source_address(cli.peerhost) : datastore['SRVHOST']

    case request.method
    when 'OPTIONS'
              Severity: Minor
              Found in modules/auxiliary/gather/ie_sandbox_findfiles.rb - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 10 locations. Consider refactoring.
              Open

                def process_options(cli, request)
    print_status("OPTIONS #{request.uri}")
    headers = {
      'MS-Author-Via' => 'DAV',
      'DASL'          => '<DAV:sql>',
              Severity: Major
              Found in modules/auxiliary/gather/ie_sandbox_findfiles.rb and 9 other locations - About 50 mins to fix
              modules/auxiliary/server/capture/http_ntlm.rb on lines 97..111
              modules/auxiliary/server/http_ntlmrelay.rb on lines 124..138
              modules/exploits/windows/browser/ubisoft_uplay_cmd_exec.rb on lines 171..185
              modules/exploits/windows/browser/webdav_dll_hijacker.rb on lines 125..139
              modules/exploits/windows/fileformat/mcafee_showreport_exec.rb on lines 101..116
              modules/exploits/windows/http/sap_host_control_cmd_exec.rb on lines 117..131
              modules/exploits/windows/misc/vmhgfs_webdav_dll_sideload.rb on lines 113..127
              modules/exploits/windows/misc/wireshark_lua.rb on lines 106..121
              modules/exploits/windows/scada/ge_proficy_cimplicity_gefebt.rb on lines 96..110

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 43.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status