Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/auxiliary/gather/jenkins_cred_recovery.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method initialize has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(update_info(info,
      'Name'           => 'Jenkins Domain Credential Recovery',
      'Description'    => %q{
        This module will collect Jenkins domain credentials, and uses
Severity: Minor
Found in modules/auxiliary/gather/jenkins_cred_recovery.rb - About 1 hr to fix

    Method decrypt has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def decrypt(encrypted_pass)
    uri  = normalize_uri(target_uri, 'script')
    res  = send_request_cgi({
      'method'    => 'POST',
      'uri'       => uri,
    Severity: Minor
    Found in modules/auxiliary/gather/jenkins_cred_recovery.rb - About 1 hr to fix

      Method get_users has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def get_users
    users = []

    uri = normalize_uri(target_uri.path, 'credential-store', 'domain', domain)
    uri << '/'
      Severity: Minor
      Found in modules/auxiliary/gather/jenkins_cred_recovery.rb - About 1 hr to fix

        Method get_users has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

          def get_users
    users = []

    uri = normalize_uri(target_uri.path, 'credential-store', 'domain', domain)
    uri << '/'
        Severity: Minor
        Found in modules/auxiliary/gather/jenkins_cred_recovery.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method run has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

          def run
    users = get_users
    print_status("Found users for domain #{domain}: #{users.length}")

    users.each do |user_data|
        Severity: Minor
        Found in modules/auxiliary/gather/jenkins_cred_recovery.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status