Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/auxiliary/gather/jetty_web_inf_disclosure.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method initialize has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'Jetty WEB-INF File Disclosure',
Severity: Minor
Found in modules/auxiliary/gather/jetty_web_inf_disclosure.rb - About 1 hr to fix

    Method check has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

      def check
    res = send_request_cgi('uri' => '/')
    return Exploit::CheckCode::Unknown("#{peer} - Could not connect to web service - no response") if res.nil?
    return Exploit::CheckCode::Safe("#{peer} - Check URI Path, unexpected HTTP response code: #{res.code}") unless res.code == 200
    return Exploit::CheckCode::Safe("#{peer} - No Server header found") unless res.headers['Server']
    Severity: Minor
    Found in modules/auxiliary/gather/jetty_web_inf_disclosure.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

          return Exploit::CheckCode::Appears
    Severity: Major
    Found in modules/auxiliary/gather/jetty_web_inf_disclosure.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

            return Exploit::CheckCode::Detected
      Severity: Major
      Found in modules/auxiliary/gather/jetty_web_inf_disclosure.rb - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status