Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/auxiliary/gather/searchengine_subdomains_collector.rb

Summary

Maintainability
C
1 day
Test Coverage

Method search_subdomains has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

  def search_subdomains(target)
    domains = {}
    ipv4 = Rex::Socket.is_ipv4?(target)
    dork = ipv4 ? "ip:#{target}" : "domain:#{target}"
Severity: Minor
Found in modules/auxiliary/gather/searchengine_subdomains_collector.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method bing_search has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def bing_search(dork)
    print_status("Searching Bing for subdomains from #{dork}")
    results = []

    begin
Severity: Minor
Found in modules/auxiliary/gather/searchengine_subdomains_collector.rb - About 1 hr to fix

    Method yahoo_search has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def yahoo_search(dork)
    print_status("Searching Yahoo for subdomains from #{dork}")
    results = []

    begin
    Severity: Minor
    Found in modules/auxiliary/gather/searchengine_subdomains_collector.rb - About 1 hr to fix

      Method bing_search has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

        def bing_search(dork)
    print_status("Searching Bing for subdomains from #{dork}")
    results = []

    begin
      Severity: Minor
      Found in modules/auxiliary/gather/searchengine_subdomains_collector.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method yahoo_search has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

        def yahoo_search(dork)
    print_status("Searching Yahoo for subdomains from #{dork}")
    results = []

    begin
      Severity: Minor
      Found in modules/auxiliary/gather/searchengine_subdomains_collector.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status