Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/auxiliary/gather/splunk_raw_server_info.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method initialize has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'Splunk __raw Server Info Disclosure ',
Severity: Minor
Found in modules/auxiliary/gather/splunk_raw_server_info.rb - About 1 hr to fix

    Method authenticate has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def authenticate
    login_url = normalize_uri(target_uri.path, 'en-US', 'account', 'login')

    res = send_request_cgi({
      'method' => 'GET',
    Severity: Minor
    Found in modules/auxiliary/gather/splunk_raw_server_info.rb - About 1 hr to fix

      Method authenticate has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def authenticate
    login_url = normalize_uri(target_uri.path, 'en-US', 'account', 'login')

    res = send_request_cgi({
      'method' => 'GET',
      Severity: Minor
      Found in modules/auxiliary/gather/splunk_raw_server_info.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            update_info(
        info,
        'Name' => 'Splunk __raw Server Info Disclosure ',
        'Description' => %q{
          Splunk 6.2.3 through 7.0.1 allows information disclosure by appending
      Severity: Minor
      Found in modules/auxiliary/gather/splunk_raw_server_info.rb and 1 other location - About 40 mins to fix
      modules/auxiliary/scanner/http/wp_woocommerce_payments_add_user.rb on lines 13..41

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 38.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

          register_options(
      [
        Opt::RPORT(8000),
        OptString.new('USERNAME', [ false, 'User to login with', 'admin']),
        OptString.new('PASSWORD', [ false, 'Password to login with', '']),
      Severity: Minor
      Found in modules/auxiliary/gather/splunk_raw_server_info.rb and 4 other locations - About 15 mins to fix
      modules/auxiliary/scanner/http/chef_webui_login.rb on lines 34..40
      modules/exploits/linux/http/kibana_upgrade_assistant_telemetry_rce.rb on lines 58..64
      modules/exploits/windows/http/hp_sitescope_dns_tool.rb on lines 55..61
      modules/exploits/windows/http/pgadmin_binary_path_api.rb on lines 52..58

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 26.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status