Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/auxiliary/gather/xerox_workcentre_5xxx_ldap.rb

Summary

Maintainability
C
1 day
Test Coverage

File xerox_workcentre_5xxx_ldap.rb has 260 lines of code (exceeds 250 allowed). Consider refactoring.
Open

class MetasploitModule < Msf::Auxiliary
  include Msf::Exploit::Remote::HttpClient
  include Msf::Exploit::Remote::TcpServer
  include Msf::Auxiliary::Report
Severity: Minor
Found in modules/auxiliary/gather/xerox_workcentre_5xxx_ldap.rb - About 2 hrs to fix

    Method run has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

      def run
    print_status("Attempting to extract LDAP username and password...")

    @auth_cookie = default_page
    if @auth_cookie.blank?
    Severity: Minor
    Found in modules/auxiliary/gather/xerox_workcentre_5xxx_ldap.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method restore_ldap_server has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def restore_ldap_server
    ldap_restore_page = '/dummypost/xerox.set'
    ldap_restore_vars = {
      '_fun_function' => 'HTTP_Set_Config_Attrib_fn',
      'NextPage' => '/ldap/index.php?ldapaction=add',
    Severity: Minor
    Found in modules/auxiliary/gather/xerox_workcentre_5xxx_ldap.rb - About 1 hr to fix

      Method run has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def run
    print_status("Attempting to extract LDAP username and password...")

    @auth_cookie = default_page
    if @auth_cookie.blank?
      Severity: Minor
      Found in modules/auxiliary/gather/xerox_workcentre_5xxx_ldap.rb - About 1 hr to fix

        Method trigger_ldap_request has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def trigger_ldap_request
    ldap_trigger_page = '/userpost/xerox.set'
    ldap_trigger_vars = {
      'nameSchema'=>'givenName',
      'emailSchema'=>'mail',
        Severity: Minor
        Found in modules/auxiliary/gather/xerox_workcentre_5xxx_ldap.rb - About 1 hr to fix

          Method register_creds has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

            def register_creds(service_name, remote_host, remote_port, username, password)
          Severity: Minor
          Found in modules/auxiliary/gather/xerox_workcentre_5xxx_ldap.rb - About 35 mins to fix

            Avoid too many return statements within this method.
            Open

                  return
            Severity: Major
            Found in modules/auxiliary/gather/xerox_workcentre_5xxx_ldap.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                  return unless status
              Severity: Major
              Found in modules/auxiliary/gather/xerox_workcentre_5xxx_ldap.rb - About 30 mins to fix

                Identical blocks of code found in 3 locations. Consider refactoring.
                Open

                  def register_creds(service_name, remote_host, remote_port, username, password)
    credential_data = {
      origin_type: :service,
      module_fullname: self.fullname,
      workspace_id: myworkspace_id,
                Severity: Major
                Found in modules/auxiliary/gather/xerox_workcentre_5xxx_ldap.rb and 2 other locations - About 1 hr to fix
                modules/auxiliary/gather/konica_minolta_pwd_extract.rb on lines 228..256
                modules/auxiliary/gather/xerox_pwd_extract.rb on lines 180..208

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 52.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                    ldap_trigger_vars = {
      'nameSchema'=>'givenName',
      'emailSchema'=>'mail',
      'phoneSchema'=>'telephoneNumber',
      'postalSchema'=>'postalAddress',
                Severity: Minor
                Found in modules/auxiliary/gather/xerox_workcentre_5xxx_ldap.rb and 2 other locations - About 35 mins to fix
                modules/exploits/linux/http/cisco_rv32x_rce.rb on lines 147..164
                plugins/session_notifier.rb on lines 22..39

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 35.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status