Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/auxiliary/pdf/foxit/authbypass.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method make_pdf has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def make_pdf(exec)

    xref = []
    eol = "\x0d\x0a"
    endobj = "endobj" << eol
Severity: Minor
Found in modules/auxiliary/pdf/foxit/authbypass.rb - About 1 hr to fix

    Identical blocks of code found in 20 locations. Consider refactoring.
    Open

      def n_obfu(str)
    result = ""
    str.scan(/./u) do |c|
      if rand(2) == 0 and c.upcase >= 'A' and c.upcase <= 'Z'
        result << "#%x" % c.unpack('C*')[0]
    Severity: Major
    Found in modules/auxiliary/pdf/foxit/authbypass.rb and 19 other locations - About 40 mins to fix
    modules/exploits/multi/fileformat/adobe_u3d_meshcont.rb on lines 190..200
    modules/exploits/windows/browser/adobe_cooltype_sing.rb on lines 363..373
    modules/exploits/windows/browser/adobe_flashplayer_newfunction.rb on lines 259..268
    modules/exploits/windows/browser/adobe_flatedecode_predictor02.rb on lines 133..142
    modules/exploits/windows/browser/adobe_geticon.rb on lines 144..153
    modules/exploits/windows/browser/adobe_media_newplayer.rb on lines 159..168
    modules/exploits/windows/browser/adobe_toolbutton.rb on lines 191..201
    modules/exploits/windows/browser/adobe_utilprintf.rb on lines 123..132
    modules/exploits/windows/fileformat/adobe_collectemailinfo.rb on lines 117..126
    modules/exploits/windows/fileformat/adobe_cooltype_sing.rb on lines 350..360
    modules/exploits/windows/fileformat/adobe_flashplayer_button.rb on lines 265..274
    modules/exploits/windows/fileformat/adobe_flashplayer_newfunction.rb on lines 261..270
    modules/exploits/windows/fileformat/adobe_flatedecode_predictor02.rb on lines 128..137
    modules/exploits/windows/fileformat/adobe_libtiff.rb on lines 121..130
    modules/exploits/windows/fileformat/adobe_media_newplayer.rb on lines 160..169
    modules/exploits/windows/fileformat/adobe_pdf_embedded_exe_nojs.rb on lines 101..110
    modules/exploits/windows/fileformat/adobe_toolbutton.rb on lines 200..210
    modules/exploits/windows/fileformat/adobe_u3d_meshdecl.rb on lines 268..278
    modules/exploits/windows/fileformat/adobe_utilprintf.rb on lines 114..123

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 37.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

        super(update_info(info,
      'Name'           => 'Foxit Reader Authorization Bypass',
      'Description'    => %q{
          This module exploits an authorization bypass vulnerability in Foxit Reader
        build 1120. When an attacker creates a specially crafted pdf file containing
    Severity: Minor
    Found in modules/auxiliary/pdf/foxit/authbypass.rb and 4 other locations - About 20 mins to fix
    modules/auxiliary/dos/wireshark/capwap.rb on lines 11..30
    modules/auxiliary/gather/huawei_wifi_info.rb on lines 53..73
    modules/auxiliary/scanner/http/manageengine_deviceexpert_user_creds.rb on lines 12..34
    modules/auxiliary/scanner/tftp/netdecision_tftp.rb on lines 11..30

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 27.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status