Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/auxiliary/scanner/couchdb/couchdb_enum.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Method get_dbs has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def get_dbs(auth)
    begin
      res = send_request_cgi(
        'uri'    => normalize_uri(target_uri.path),
        'method' => 'GET'
Severity: Minor
Found in modules/auxiliary/scanner/couchdb/couchdb_enum.rb - About 1 hr to fix

    Method initialize has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize(info = {})
    super(update_info(info,
      'Name'        => 'CouchDB Enum Utility',
      'Description' => %q{
        This module enumerates databases on CouchDB using the REST API
    Severity: Minor
    Found in modules/auxiliary/scanner/couchdb/couchdb_enum.rb - About 1 hr to fix

      Method get_version has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def get_version
    @version = nil

    begin
      res = send_request_cgi(
      Severity: Minor
      Found in modules/auxiliary/scanner/couchdb/couchdb_enum.rb - About 1 hr to fix

        Method get_version has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

          def get_version
    @version = nil

    begin
      res = send_request_cgi(
        Severity: Minor
        Found in modules/auxiliary/scanner/couchdb/couchdb_enum.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method run has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

          def run
    username = datastore['HttpUsername']
    password = datastore['HttpPassword']

    if datastore['CREATEUSER']
        Severity: Minor
        Found in modules/auxiliary/scanner/couchdb/couchdb_enum.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

              return true
        Severity: Major
        Found in modules/auxiliary/scanner/couchdb/couchdb_enum.rb - About 30 mins to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              if res && res.code == 200
      res_json = res.get_json_document

      if res_json.empty?
        vprint_bad("#{peer} - Cannot parse the response, seems like it's not CouchDB.")
          Severity: Minor
          Found in modules/auxiliary/scanner/couchdb/couchdb_enum.rb and 1 other location - About 30 mins to fix
          modules/exploits/linux/http/apache_couchdb_cmd_exec.rb on lines 158..168

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 32.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status