Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/auxiliary/scanner/finger/finger_users.rb

Summary

Maintainability
D
1 day
Test Coverage

Method parse_users has a Cognitive Complexity of 44 (exceeds 5 allowed). Consider refactoring.
Open

  def parse_users(buff)
    buff.each_line do |line|
      uid = nil
      next if line.strip.empty?
Severity: Minor
Found in modules/auxiliary/scanner/finger/finger_users.rb - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method finger_list has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
Open

  def finger_list
    if !@multiple_requests
      finger_user_common.each do |user|
        next if @users[user]
        connect
Severity: Minor
Found in modules/auxiliary/scanner/finger/finger_users.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method parse_users has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def parse_users(buff)
    buff.each_line do |line|
      uid = nil
      next if line.strip.empty?
Severity: Minor
Found in modules/auxiliary/scanner/finger/finger_users.rb - About 1 hr to fix

    Method finger_list has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def finger_list
    if !@multiple_requests
      finger_user_common.each do |user|
        next if @users[user]
        connect
    Severity: Minor
    Found in modules/auxiliary/scanner/finger/finger_users.rb - About 1 hr to fix

      Method run_host has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def run_host(ip)
    @users = {}

    begin
      vprint_status "#{rhost}:#{rport} - Sending empty finger request."
      Severity: Minor
      Found in modules/auxiliary/scanner/finger/finger_users.rb - About 1 hr to fix

        Method finger_slurp_data has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          def finger_slurp_data
    buff = ""
    begin
      while(res = sock.get_once(-1, 5) || '')
        buff << res
        Severity: Minor
        Found in modules/auxiliary/scanner/finger/finger_users.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status