modules/auxiliary/scanner/http/allegro_rompager_misfortune_cookie.rb
Method test_misfortune
has 43 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
def test_misfortune
# find a usable canary URI (one that returns an acceptable status code already)
if canary = find_canary
canary_value, canary_code = canary
vprint_status("#{peer} found canary URI #{canary_value} with code #{canary_code}")
Method test_misfortune
has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
Open
def test_misfortune
# find a usable canary URI (one that returns an acceptable status code already)
if canary = find_canary
canary_value, canary_code = canary
vprint_status("#{peer} found canary URI #{canary_value} with code #{canary_code}")
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method initialize
has 34 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
def initialize(info = {})
super(update_info(
info,
'Name' => "Allegro Software RomPager 'Misfortune Cookie' (CVE-2014-9222) Scanner",
'Description' => %q(
Avoid too many return
statements within this method. Open
Open
return check_response_fingerprint(res, Exploit::CheckCode::Detected)
Avoid too many return
statements within this method. Open
Open
return Exploit::CheckCode::Vulnerable