rapid7/metasploit-framework

View on GitHub
modules/auxiliary/scanner/http/appletv_login.rb

Summary

Maintainability
A
4 hrs
Test Coverage

Method run_host has 49 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def run_host(ip)
    uri = "/stop"
    if datastore['PASS_FILE'] && !datastore['PASS_FILE'].empty?
      print_status("Attempting to login to #{uri} using password list")
      cred_collection = Metasploit::Framework::CredentialCollection.new(
Severity: Minor
Found in modules/auxiliary/scanner/http/appletv_login.rb - About 1 hr to fix

    Method initialize has 40 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize
        super(
            'Name'           => 'AppleTV AirPlay Login Utility',
            'Description'    => %q(
            This module attempts to authenticate to an AppleTV service with
    Severity: Minor
    Found in modules/auxiliary/scanner/http/appletv_login.rb - About 1 hr to fix

      Method run_host has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def run_host(ip)
          uri = "/stop"
          if datastore['PASS_FILE'] && !datastore['PASS_FILE'].empty?
            print_status("Attempting to login to #{uri} using password list")
            cred_collection = Metasploit::Framework::CredentialCollection.new(
      Severity: Minor
      Found in modules/auxiliary/scanner/http/appletv_login.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status