Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/auxiliary/scanner/http/dell_idrac.rb

Summary

Maintainability
D
2 days
Test Coverage

Method run_host has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

  def run_host(ip)
    print_status("Verifying that login page exists at #{ip}")
    server_response = false
    @blockingtime = 0
    begin
Severity: Minor
Found in modules/auxiliary/scanner/http/dell_idrac.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run_host has 57 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def run_host(ip)
    print_status("Verifying that login page exists at #{ip}")
    server_response = false
    @blockingtime = 0
    begin
Severity: Major
Found in modules/auxiliary/scanner/http/dell_idrac.rb - About 2 hrs to fix

    Method do_login_v9 has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

      def do_login_v9(user = nil, pass = nil)
    if @blockingtime > 0
      sleep(@blockingtime)
    end
    uri = v9_url
    Severity: Minor
    Found in modules/auxiliary/scanner/http/dell_idrac.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method do_login_v9 has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def do_login_v9(user = nil, pass = nil)
    if @blockingtime > 0
      sleep(@blockingtime)
    end
    uri = v9_url
    Severity: Minor
    Found in modules/auxiliary/scanner/http/dell_idrac.rb - About 1 hr to fix

      Method do_login_pre9 has 38 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def do_login_pre9(user = nil, pass = nil)
    if @blockingtime > 0
      sleep(@blockingtime)
    end
    uri = pre_v9_url
      Severity: Minor
      Found in modules/auxiliary/scanner/http/dell_idrac.rb - About 1 hr to fix

        Method initialize has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def initialize
    super(
      'Name' => 'Dell iDRAC Default Login',
      'Description' => %q{
        This module attempts to login to a iDRAC webserver instance using
        Severity: Minor
        Found in modules/auxiliary/scanner/http/dell_idrac.rb - About 1 hr to fix

          Method do_login_pre9 has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

            def do_login_pre9(user = nil, pass = nil)
    if @blockingtime > 0
      sleep(@blockingtime)
    end
    uri = pre_v9_url
          Severity: Minor
          Found in modules/auxiliary/scanner/http/dell_idrac.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this method.
          Open

                  return :abort
          Severity: Major
          Found in modules/auxiliary/scanner/http/dell_idrac.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                  return if (e.to_s.match(/^SSL_connect /)) # strange errors / exception if SSL connection aborted
            Severity: Major
            Found in modules/auxiliary/scanner/http/dell_idrac.rb - About 30 mins to fix

              Identical blocks of code found in 3 locations. Consider refactoring.
              Open

                def report_cred(opts)
    service_data = {
      address: opts[:ip],
      port: opts[:port],
      service_name: opts[:service_name],
              Severity: Major
              Found in modules/auxiliary/scanner/http/dell_idrac.rb and 2 other locations - About 1 hr to fix
              modules/auxiliary/scanner/http/apache_nifi_login.rb on lines 48..72
              modules/exploits/windows/misc/unified_remote_rce.rb on lines 460..484

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 60.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                    print_good("#{target_url} - SUCCESSFUL login for user '#{user}' with password '#{pass}'")
      report_cred(
        ip: rhost,
        port: rport,
        service_name: (ssl ? 'https' : 'http'),
              Severity: Minor
              Found in modules/auxiliary/scanner/http/dell_idrac.rb and 1 other location - About 30 mins to fix
              modules/auxiliary/scanner/http/dell_idrac.rb on lines 143..153

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 33.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                    print_good("#{target_url} - SUCCESSFUL login for user '#{user}' with password '#{pass}'")
      report_cred(
        ip: rhost,
        port: rport,
        service_name: (ssl ? 'https' : 'http'),
              Severity: Minor
              Found in modules/auxiliary/scanner/http/dell_idrac.rb and 1 other location - About 30 mins to fix
              modules/auxiliary/scanner/http/dell_idrac.rb on lines 88..98

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 33.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                def target_url
    proto = 'http'
    if (rport == 443) || ssl
      proto = 'https'
    end
              Severity: Minor
              Found in modules/auxiliary/scanner/http/dell_idrac.rb and 1 other location - About 20 mins to fix
              modules/auxiliary/scanner/http/fortimail_login_bypass_detection.rb on lines 41..47

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 28.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                      elsif res.code == 301
          print_error("#{target_url} - Page redirect to #{res.headers['Location']}")
          return :abort
        else
          print_error("The iDRAC login page not detected on #{ip}")
              Severity: Minor
              Found in modules/auxiliary/scanner/http/dell_idrac.rb and 1 other location - About 15 mins to fix
              modules/auxiliary/scanner/http/dell_idrac.rb on lines 230..236

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 25.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                        elsif res.code == 301
            print_error("#{target_url} - Page redirect to #{res.headers['Location']}")
            return :abort
          else
            print_error("The iDRAC login page not detected on #{ip}")
              Severity: Minor
              Found in modules/auxiliary/scanner/http/dell_idrac.rb and 1 other location - About 15 mins to fix
              modules/auxiliary/scanner/http/dell_idrac.rb on lines 203..209

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 25.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status