Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/auxiliary/scanner/http/frontpage_login.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Method run_host has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

  def run_host(target_host)

    if datastore['RPORT'].to_i == 80 or datastore['RPORT'].to_i == 443
      port = ""
    else
Severity: Minor
Found in modules/auxiliary/scanner/http/frontpage_login.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method check_account has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def check_account(info, fpversion, target_host)

    return if not fpversion

    connect
Severity: Minor
Found in modules/auxiliary/scanner/http/frontpage_login.rb - About 1 hr to fix

    Method run_host has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def run_host(target_host)

    if datastore['RPORT'].to_i == 80 or datastore['RPORT'].to_i == 443
      port = ""
    else
    Severity: Minor
    Found in modules/auxiliary/scanner/http/frontpage_login.rb - About 1 hr to fix

      Method check_account has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

        def check_account(info, fpversion, target_host)

    return if not fpversion

    connect
      Severity: Minor
      Found in modules/auxiliary/scanner/http/frontpage_login.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status