Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/auxiliary/scanner/http/mediawiki_svg_fileaccess.rb

Summary

Maintainability
C
1 day
Test Coverage

Method accessfile has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def accessfile(rhost)
    vprint_status("#{peer} MediaWiki - Getting unauthenticated session...")
    @wiki_session_name, @wiki_session = get_first_session
    if @wiki_session.nil?
      print_error("#{peer} MediaWiki - Failed to get unauthenticated session...")
Severity: Minor
Found in modules/auxiliary/scanner/http/mediawiki_svg_fileaccess.rb - About 1 hr to fix

    Method upload_file has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def upload_file
    entity = Rex::Text.rand_text_alpha_lower(3)
    @file_name = Rex::Text.rand_text_alpha_lower(4)
    svg_file = %Q|
    <!DOCTYPE svg [<!ENTITY #{entity} SYSTEM "file://#{datastore['RFILE']}">]>
    Severity: Minor
    Found in modules/auxiliary/scanner/http/mediawiki_svg_fileaccess.rb - About 1 hr to fix

      Method initialize has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def initialize
    super(
      'Name'         => 'MediaWiki SVG XML Entity Expansion Remote File Access',
      'Description'  =>  %q{
          This module attempts to read a remote file from the server using a vulnerability
      Severity: Minor
      Found in modules/auxiliary/scanner/http/mediawiki_svg_fileaccess.rb - About 1 hr to fix

        Method accessfile has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

          def accessfile(rhost)
    vprint_status("#{peer} MediaWiki - Getting unauthenticated session...")
    @wiki_session_name, @wiki_session = get_first_session
    if @wiki_session.nil?
      print_error("#{peer} MediaWiki - Failed to get unauthenticated session...")
        Severity: Minor
        Found in modules/auxiliary/scanner/http/mediawiki_svg_fileaccess.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method upload_file has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

          def upload_file
    entity = Rex::Text.rand_text_alpha_lower(3)
    @file_name = Rex::Text.rand_text_alpha_lower(4)
    svg_file = %Q|
    <!DOCTYPE svg [<!ENTITY #{entity} SYSTEM "file://#{datastore['RFILE']}">]>
        Severity: Minor
        Found in modules/auxiliary/scanner/http/mediawiki_svg_fileaccess.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

              return
        Severity: Major
        Found in modules/auxiliary/scanner/http/mediawiki_svg_fileaccess.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                return
          Severity: Major
          Found in modules/auxiliary/scanner/http/mediawiki_svg_fileaccess.rb - About 30 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  Opt::RPORT(80),
      OptString.new('TARGETURI', [true, 'Path to MediaWiki', '/mediawiki']),
      OptString.new('RFILE', [true, 'Remote File', '/etc/passwd']),
      OptString.new('USERNAME', [ false,  "The user to authenticate as"]),
      OptString.new('PASSWORD', [ false,  "The password to authenticate with" ])
            Severity: Minor
            Found in modules/auxiliary/scanner/http/mediawiki_svg_fileaccess.rb and 1 other location - About 25 mins to fix
            lib/msf/core/exploit/remote/winrm.rb on lines 25..29

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 30.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status