Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/auxiliary/scanner/http/nagios_xi_scanner.rb

Summary

Maintainability
C
1 day
Test Coverage

Method run_host has 64 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def run_host(_target_host)
    # Check if we have a valid version to test
    if version
      if version.empty?
        print_error('VERSION cannot be empty. Please provide an existing Nagios XI VERSION or use `unset VERSION` to cancel')
Severity: Major
Found in modules/auxiliary/scanner/http/nagios_xi_scanner.rb - About 2 hrs to fix

    Method run_host has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

      def run_host(_target_host)
    # Check if we have a valid version to test
    if version
      if version.empty?
        print_error('VERSION cannot be empty. Please provide an existing Nagios XI VERSION or use `unset VERSION` to cancel')
    Severity: Minor
    Found in modules/auxiliary/scanner/http/nagios_xi_scanner.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method rce_check has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def rce_check(version, real_target: false)
    version_type, clean_version = parse_version(version)
    if version_type == 'unsupported'
      print_error("Invalid version format: `#{version}`. Please provide an existing Nagios XI version or use `unset VERSION` to cancel")
      return
    Severity: Minor
    Found in modules/auxiliary/scanner/http/nagios_xi_scanner.rb - About 1 hr to fix

      Method rce_check has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        def rce_check(version, real_target: false)
    version_type, clean_version = parse_version(version)
    if version_type == 'unsupported'
      print_error("Invalid version format: `#{version}`. Please provide an existing Nagios XI version or use `unset VERSION` to cancel")
      return
      Severity: Minor
      Found in modules/auxiliary/scanner/http/nagios_xi_scanner.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

            return
      Severity: Major
      Found in modules/auxiliary/scanner/http/nagios_xi_scanner.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                return
        Severity: Major
        Found in modules/auxiliary/scanner/http/nagios_xi_scanner.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                  return
          Severity: Major
          Found in modules/auxiliary/scanner/http/nagios_xi_scanner.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                    return
            Severity: Major
            Found in modules/auxiliary/scanner/http/nagios_xi_scanner.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                    return
              Severity: Major
              Found in modules/auxiliary/scanner/http/nagios_xi_scanner.rb - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                    return
                Severity: Major
                Found in modules/auxiliary/scanner/http/nagios_xi_scanner.rb - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                          return
                  Severity: Major
                  Found in modules/auxiliary/scanner/http/nagios_xi_scanner.rb - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                            return
                    Severity: Major
                    Found in modules/auxiliary/scanner/http/nagios_xi_scanner.rb - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                              return
                      Severity: Major
                      Found in modules/auxiliary/scanner/http/nagios_xi_scanner.rb - About 30 mins to fix

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                              case login_result
      when 1..3 # An error occurred
        print_error("#{rhost}:#{rport} - #{res_array[0]}")
        return
      when 4 # Nagios XI is still not fully installed
                        Severity: Minor
                        Found in modules/auxiliary/scanner/http/nagios_xi_scanner.rb and 1 other location - About 25 mins to fix
                        modules/auxiliary/scanner/http/nagios_xi_scanner.rb on lines 195..202

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 30.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                              case login_result
      when 1..3
        print_error("#{rhost}:#{rport} - #{res_array[0]}")
        return
      when 5 # the Nagios XI license agreement still has not been signed
                        Severity: Minor
                        Found in modules/auxiliary/scanner/http/nagios_xi_scanner.rb and 1 other location - About 25 mins to fix
                        modules/auxiliary/scanner/http/nagios_xi_scanner.rb on lines 174..181

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 30.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                              'Name' => 'Nagios XI Scanner',
      'Description' => %q{
        The module detects the version of Nagios XI applications and
        suggests matching exploit modules based on the version number.
        Since Nagios XI applications only reveal the version to authenticated
                        Severity: Minor
                        Found in modules/auxiliary/scanner/http/nagios_xi_scanner.rb and 1 other location - About 20 mins to fix
                        modules/auxiliary/scanner/http/dir_webdav_unicode_bypass.rb on lines 16..34

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 27.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        There are no issues that match your filters.

                        Category
                        Status