Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/auxiliary/scanner/http/smt_ipmi_cgi_scanner.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method run_host has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def run_host(ip)
    vprint_status("Checking if it's a Supermicro IPMI web interface...")
    if is_supermicro?
      vprint_good("Supermicro IPMI web interface found")
    else
Severity: Minor
Found in modules/auxiliary/scanner/http/smt_ipmi_cgi_scanner.rb - About 1 hr to fix

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

      def initialize(info = {})
    super(update_info(info,
      'Name'        => 'Supermicro Onboard IPMI CGI Vulnerability Scanner',
      'Description' => %q{
        This module checks for known vulnerabilities in the CGI applications of
    Severity: Minor
    Found in modules/auxiliary/scanner/http/smt_ipmi_cgi_scanner.rb and 3 other locations - About 25 mins to fix
    modules/auxiliary/admin/http/linksys_tmunblock_admin_reset_bof.rb on lines 9..32
    modules/auxiliary/admin/http/wp_custom_contact_forms.rb on lines 10..33
    modules/auxiliary/scanner/http/cisco_ios_auth_bypass.rb on lines 19..37

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 31.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

      def is_supermicro?
    res = send_request_cgi(
      {
        "uri"       => "/",
        "method"    => "GET"
    Severity: Minor
    Found in modules/auxiliary/scanner/http/smt_ipmi_cgi_scanner.rb and 1 other location - About 15 mins to fix
    modules/auxiliary/scanner/http/smt_ipmi_url_redirect_traversal.rb on lines 55..66

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 26.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

        if result
      print_good("Vulnerable to CVE-2013-3623 (close_window.cgi Buffer Overflow)")
      report_vuln({
        :host  => rhost,
        :port  => rport,
    Severity: Minor
    Found in modules/auxiliary/scanner/http/smt_ipmi_cgi_scanner.rb and 5 other locations - About 15 mins to fix
    modules/auxiliary/scanner/http/joomla_ecommercewd_sqli_scanner.rb on lines 75..82
    modules/auxiliary/scanner/http/joomla_gallerywd_sqli_scanner.rb on lines 92..99
    modules/auxiliary/scanner/http/smt_ipmi_cgi_scanner.rb on lines 130..137
    modules/auxiliary/scanner/http/wordpress_cp_calendar_sqli.rb on lines 63..70
    modules/auxiliary/scanner/http/wp_contus_video_gallery_sqli.rb on lines 55..62

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 25.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

        if result
      print_good("Vulnerable to CVE-2013-3621 (login.cgi Buffer Overflow)")
      report_vuln({
        :host  => rhost,
        :port  => rport,
    Severity: Minor
    Found in modules/auxiliary/scanner/http/smt_ipmi_cgi_scanner.rb and 5 other locations - About 15 mins to fix
    modules/auxiliary/scanner/http/joomla_ecommercewd_sqli_scanner.rb on lines 75..82
    modules/auxiliary/scanner/http/joomla_gallerywd_sqli_scanner.rb on lines 92..99
    modules/auxiliary/scanner/http/smt_ipmi_cgi_scanner.rb on lines 143..150
    modules/auxiliary/scanner/http/wordpress_cp_calendar_sqli.rb on lines 63..70
    modules/auxiliary/scanner/http/wp_contus_video_gallery_sqli.rb on lines 55..62

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 25.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status