Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/auxiliary/scanner/http/splunk_web_login.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Method do_login has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def do_login(user, pass)
    vprint_status("Trying username:'#{user}' with password:'#{pass}'")
    begin
      cval = ''
      uid, session_id_port, session_id, cval = get_login_cookie
Severity: Minor
Found in modules/auxiliary/scanner/http/splunk_web_login.rb - About 1 hr to fix

    Method initialize has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize(info={})
    super(update_info(info,
      'Name'           => 'Splunk Web Interface Login Utility',
      'Description'    => %{
        This module simply attempts to login to a Splunk web interface.  Please note the
    Severity: Minor
    Found in modules/auxiliary/scanner/http/splunk_web_login.rb - About 1 hr to fix

      Method get_login_cookie has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        def get_login_cookie
    res = send_request_raw({'uri' => datastore['URI']})

    uid             = ''
    session_id_port = ''
      Severity: Minor
      Found in modules/auxiliary/scanner/http/splunk_web_login.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method do_login has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def do_login(user, pass)
    vprint_status("Trying username:'#{user}' with password:'#{pass}'")
    begin
      cval = ''
      uid, session_id_port, session_id, cval = get_login_cookie
      Severity: Minor
      Found in modules/auxiliary/scanner/http/splunk_web_login.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

            return :abort
      Severity: Major
      Found in modules/auxiliary/scanner/http/splunk_web_login.rb - About 30 mins to fix

        Identical blocks of code found in 3 locations. Consider refactoring.
        Open

              res.get_cookies.split(';').each {|c|
        c.split(',').each {|v|
          if v.split('=')[0] =~ /cval/
            cval = v.split('=')[1]
          elsif v.split('=')[0] =~ /uid/
        Severity: Major
        Found in modules/auxiliary/scanner/http/splunk_web_login.rb and 2 other locations - About 1 hr to fix
        modules/exploits/multi/http/splunk_mappy_exec.rb on lines 123..132
        modules/exploits/multi/http/splunk_upload_app_exec.rb on lines 280..289

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 62.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 12 locations. Consider refactoring.
        Open

          def report_cred(opts)
    service_data = {
      address: opts[:ip],
      port: opts[:port],
      service_name: 'splunk-web',
        Severity: Major
        Found in modules/auxiliary/scanner/http/splunk_web_login.rb and 11 other locations - About 1 hr to fix
        modules/auxiliary/scanner/http/cisco_asa_asdm_bruteforce.rb on lines 72..96
        modules/auxiliary/scanner/http/cisco_asa_clientless_vpn.rb on lines 77..101
        modules/auxiliary/scanner/http/cisco_ssl_vpn.rb on lines 137..161
        modules/auxiliary/scanner/http/fortinet_ssl_vpn.rb on lines 90..114
        modules/auxiliary/scanner/http/infovista_enum.rb on lines 80..104
        modules/auxiliary/scanner/http/symantec_brightmail_ldapcreds.rb on lines 64..86
        modules/auxiliary/scanner/http/vcms_login.rb on lines 50..74
        modules/auxiliary/scanner/misc/cctv_dvr_login.rb on lines 130..154
        modules/auxiliary/scanner/telnet/telnet_ruggedcom.rb on lines 58..82
        modules/auxiliary/scanner/vmware/vmware_http_login.rb on lines 35..59
        modules/auxiliary/voip/asterisk_login.rb on lines 51..75

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 58.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status