Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/auxiliary/scanner/http/squid_pivot_scanning.rb

Summary

Maintainability
D
1 day
Test Coverage

Method run_host has a Cognitive Complexity of 49 (exceeds 5 allowed). Consider refactoring.
Open

  def run_host(target_host)
    begin
      iplist = Rex::Socket::RangeWalker.new(datastore['RANGE'])
      portlist = Rex::Socket.portspec_crack(datastore['PORTS'])
      dead = false
Severity: Minor
Found in modules/auxiliary/scanner/http/squid_pivot_scanning.rb - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run_host has 83 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def run_host(target_host)
    begin
      iplist = Rex::Socket::RangeWalker.new(datastore['RANGE'])
      portlist = Rex::Socket.portspec_crack(datastore['PORTS'])
      dead = false
Severity: Major
Found in modules/auxiliary/scanner/http/squid_pivot_scanning.rb - About 3 hrs to fix

    Method initialize has 40 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize
    super(
      'Name'        => 'Squid Proxy Port Scanner',
      'Description' => %q{
        A exposed Squid proxy will usually allow an attacker to make requests on
    Severity: Minor
    Found in modules/auxiliary/scanner/http/squid_pivot_scanning.rb - About 1 hr to fix

      Avoid deeply nested control flow statements.
      Open

                        if alive.nil?
                    print_good("[#{rhost}] #{target} is alive.")
                    alive = true
                  end
      Severity: Major
      Found in modules/auxiliary/scanner/http/squid_pivot_scanning.rb - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                        elsif res.body =~ /id="sysmsg".*No route to host/
                  dead = true
                  print_error("[#{rhost}] No route to #{target}")
        Severity: Major
        Found in modules/auxiliary/scanner/http/squid_pivot_scanning.rb - About 45 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              register_options(
      [
        OptString.new('RANGE', [true, 'IPs to scan through Squid proxy', '']),
        OptString.new('PORTS', [true, 'Ports to scan; must be TCP', '21,80,139,443,445,1433,1521,1723,3389,8080,9100']),
        OptBool.new('MANUAL_CHECK', [true, 'Stop the scan if server seems to answer positively to every request', true]),
          Severity: Minor
          Found in modules/auxiliary/scanner/http/squid_pivot_scanning.rb and 1 other location - About 25 mins to fix
          modules/exploits/multi/local/xorg_x11_suid_server_modulepath.rb on lines 88..94

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 30.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status