Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/auxiliary/scanner/http/vcms_login.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Method do_login has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def do_login(user, pass)
    begin
      sid = get_sid
      if sid.nil?
        vprint_error("Failed to get sid")
Severity: Minor
Found in modules/auxiliary/scanner/http/vcms_login.rb - About 1 hr to fix

    Avoid too many return statements within this method.
    Open

            return :skip_user
    Severity: Major
    Found in modules/auxiliary/scanner/http/vcms_login.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

              return :skip_user
      Severity: Major
      Found in modules/auxiliary/scanner/http/vcms_login.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

            return
        Severity: Major
        Found in modules/auxiliary/scanner/http/vcms_login.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                  return :next_user
          Severity: Major
          Found in modules/auxiliary/scanner/http/vcms_login.rb - About 30 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              def initialize(info = {})
    super(update_info(info,
      'Name'           => 'V-CMS Login Utility',
      'Description'    => %q{
        This module attempts to authenticate to an English-based V-CMS login interface. It
            Severity: Major
            Found in modules/auxiliary/scanner/http/vcms_login.rb and 1 other location - About 1 hr to fix
            modules/auxiliary/scanner/http/dolibarr_login.rb on lines 12..33

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 65.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 12 locations. Consider refactoring.
            Open

              def report_cred(opts)
    service_data = {
      address: opts[:ip],
      port: opts[:port],
      service_name: 'http',
            Severity: Major
            Found in modules/auxiliary/scanner/http/vcms_login.rb and 11 other locations - About 1 hr to fix
            modules/auxiliary/scanner/http/cisco_asa_asdm_bruteforce.rb on lines 72..96
            modules/auxiliary/scanner/http/cisco_asa_clientless_vpn.rb on lines 77..101
            modules/auxiliary/scanner/http/cisco_ssl_vpn.rb on lines 137..161
            modules/auxiliary/scanner/http/fortinet_ssl_vpn.rb on lines 90..114
            modules/auxiliary/scanner/http/infovista_enum.rb on lines 80..104
            modules/auxiliary/scanner/http/splunk_web_login.rb on lines 127..151
            modules/auxiliary/scanner/http/symantec_brightmail_ldapcreds.rb on lines 64..86
            modules/auxiliary/scanner/misc/cctv_dvr_login.rb on lines 130..154
            modules/auxiliary/scanner/telnet/telnet_ruggedcom.rb on lines 58..82
            modules/auxiliary/scanner/vmware/vmware_http_login.rb on lines 35..59
            modules/auxiliary/voip/asterisk_login.rb on lines 51..75

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 58.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status