Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/auxiliary/scanner/http/vicidial_multiple_sqli.rb

Summary

Maintainability
D
1 day
Test Coverage

Method post_4a has 138 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def post_4a
    {
      'ADD' => '4A',
      'custom_fields_modify' => '0',
      'user' => '111',
Severity: Major
Found in modules/auxiliary/scanner/http/vicidial_multiple_sqli.rb - About 5 hrs to fix

    Method run_host has 72 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def run_host(ip)
    res = send_request_cgi({
      'method' => 'GET',
      'uri' => normalize_uri(target_uri.path, 'vicidial', 'admin.php'),
      'headers' => basic_auth
    Severity: Major
    Found in modules/auxiliary/scanner/http/vicidial_multiple_sqli.rb - About 2 hrs to fix

      File vicidial_multiple_sqli.rb has 285 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      class MetasploitModule < Msf::Auxiliary
  include Msf::Exploit::Remote::HttpClient
  include Msf::Auxiliary::Scanner
  include Msf::Exploit::SQLi
      Severity: Minor
      Found in modules/auxiliary/scanner/http/vicidial_multiple_sqli.rb - About 2 hrs to fix

        Method initialize has 46 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'VICIdial Multiple Authenticated SQLi',
        Severity: Minor
        Found in modules/auxiliary/scanner/http/vicidial_multiple_sqli.rb - About 1 hr to fix

          Method run_host has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

            def run_host(ip)
    res = send_request_cgi({
      'method' => 'GET',
      'uri' => normalize_uri(target_uri.path, 'vicidial', 'admin.php'),
      'headers' => basic_auth
          Severity: Minor
          Found in modules/auxiliary/scanner/http/vicidial_multiple_sqli.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status