rapid7/metasploit-framework

View on GitHub
modules/auxiliary/scanner/http/wp_paid_membership_pro_code_sqli.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method run_host has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def run_host(ip)
    id = Rex::Text.rand_text_numeric(1..10)
    @sqli = create_sqli(dbms: MySQLi::TimeBasedBlind) do |payload|
      res = send_request_cgi({
        'keep_cookies' => true,
Severity: Minor
Found in modules/auxiliary/scanner/http/wp_paid_membership_pro_code_sqli.rb - About 1 hr to fix

    Method initialize has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize(info = {})
        super(
          update_info(
            info,
            'Name' => 'Wordpress Paid Membership Pro code Unauthenticated SQLi',
    Severity: Minor
    Found in modules/auxiliary/scanner/http/wp_paid_membership_pro_code_sqli.rb - About 1 hr to fix

      Similar blocks of code found in 8 locations. Consider refactoring.
      Open

          data.each do |user|
            create_credential({
              workspace_id: myworkspace_id,
              origin_type: :service,
              module_fullname: fullname,
      modules/auxiliary/scanner/http/wp_abandoned_cart_sqli.rb on lines 120..135
      modules/auxiliary/scanner/http/wp_email_sub_news_sqli.rb on lines 83..98
      modules/auxiliary/scanner/http/wp_learnpress_sqli.rb on lines 104..119
      modules/auxiliary/scanner/http/wp_loginizer_log_sqli.rb on lines 113..128
      modules/auxiliary/scanner/http/wp_modern_events_calendar_sqli.rb on lines 87..102
      modules/auxiliary/scanner/http/wp_registrationmagic_sqli.rb on lines 100..115
      modules/auxiliary/scanner/http/wp_secure_copy_content_protection_sqli.rb on lines 97..112

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

        def check_host(_ip)
          unless wordpress_and_online?
            return Msf::Exploit::CheckCode::Safe('Server not online or not detected as wordpress')
          end
      
      
      modules/auxiliary/admin/http/wp_masterstudy_privesc.rb on lines 48..58
      modules/auxiliary/scanner/http/wp_secure_copy_content_protection_sqli.rb on lines 57..67

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 28.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status