Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/auxiliary/scanner/ip/ipidseq.rb

Summary

Maintainability
C
1 day
Test Coverage

Method analyze has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

  def analyze(ipids)
    allzeros = true
    allsame = true
    mul256 = true
    inc = true
Severity: Minor
Found in modules/auxiliary/scanner/ip/ipidseq.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method probereply has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

  def probereply(pcap, to)
    reply = nil

    begin
      Timeout.timeout(to) do
Severity: Minor
Found in modules/auxiliary/scanner/ip/ipidseq.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method analyze has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def analyze(ipids)
    allzeros = true
    allsame = true
    mul256 = true
    inc = true
Severity: Minor
Found in modules/auxiliary/scanner/ip/ipidseq.rb - About 1 hr to fix

    Method run_host has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

      def run_host(ip)
    open_pcap

    raise "SAMPLES option must be >= 2" if datastore['SAMPLES'] < 2
    Severity: Minor
    Found in modules/auxiliary/scanner/ip/ipidseq.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

        return "Constant" if allsame
    Severity: Major
    Found in modules/auxiliary/scanner/ip/ipidseq.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

          return "Broken little-endian incremental!" if mul256
      Severity: Major
      Found in modules/auxiliary/scanner/ip/ipidseq.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

            return "Incremental!" if inc
        Severity: Major
        Found in modules/auxiliary/scanner/ip/ipidseq.rb - About 30 mins to fix

          There are no issues that match your filters.

          Category
          Status