rapid7/metasploit-framework

View on GitHub
modules/auxiliary/scanner/ipmi/ipmi_dumphashes.rb

Summary

Maintainability
D
3 days
Test Coverage

Method run_host has a Cognitive Complexity of 79 (exceeds 5 allowed). Consider refactoring.
Open

  def run_host(ip)

    ipmi_status("Sending IPMI probes")

    usernames = []
Severity: Minor
Found in modules/auxiliary/scanner/ipmi/ipmi_dumphashes.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run_host has 136 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def run_host(ip)

    ipmi_status("Sending IPMI probes")

    usernames = []
Severity: Major
Found in modules/auxiliary/scanner/ipmi/ipmi_dumphashes.rb - About 5 hrs to fix

    File ipmi_dumphashes.rb has 269 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class MetasploitModule < Msf::Auxiliary
      include Msf::Auxiliary::Report
      include Msf::Auxiliary::Scanner
    
      def initialize
    Severity: Minor
    Found in modules/auxiliary/scanner/ipmi/ipmi_dumphashes.rb - About 2 hrs to fix

      Method initialize has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def initialize
          super(
            'Name'        => 'IPMI 2.0 RAKP Remote SHA1 Password Hash Retrieval',
            'Description' => %q|
              This module identifies IPMI 2.0-compatible systems and attempts to retrieve the
      Severity: Minor
      Found in modules/auxiliary/scanner/ipmi/ipmi_dumphashes.rb - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              'Name'        => 'IPMI 2.0 RAKP Remote SHA1 Password Hash Retrieval',
              'Description' => %q|
                This module identifies IPMI 2.0-compatible systems and attempts to retrieve the
                HMAC-SHA1 password hashes of default usernames. The hashes can be stored in a
                file using the OUTPUT_FILE option and then cracked using hmac_sha1_crack.rb
        Severity: Minor
        Found in modules/auxiliary/scanner/ipmi/ipmi_dumphashes.rb and 1 other location - About 25 mins to fix
        modules/auxiliary/scanner/ipmi/ipmi_cipher_zero.rb on lines 13..31

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 31.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          def process_opensession_reply(data, shost, sport)
            shost = shost.sub(/^::ffff:/, '')
            info = Rex::Proto::IPMI::Open_Session_Reply.new.read(data) rescue nil
            return unless info && info.session_payload_type == Rex::Proto::IPMI::PAYLOAD_RMCPPLUSOPEN_REP
            info
        Severity: Minor
        Found in modules/auxiliary/scanner/ipmi/ipmi_dumphashes.rb and 1 other location - About 25 mins to fix
        modules/auxiliary/scanner/ipmi/ipmi_dumphashes.rb on lines 260..264

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 31.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          def process_rakp1_reply(data, shost, sport)
            shost = shost.sub(/^::ffff:/, '')
            info = Rex::Proto::IPMI::RAKP2.new.read(data) rescue nil
            return unless info && info.session_payload_type == Rex::Proto::IPMI::PAYLOAD_RAKP2
            info
        Severity: Minor
        Found in modules/auxiliary/scanner/ipmi/ipmi_dumphashes.rb and 1 other location - About 25 mins to fix
        modules/auxiliary/scanner/ipmi/ipmi_dumphashes.rb on lines 253..257

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 31.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            if datastore['OUTPUT_JOHN_FILE']
              ::File.open(datastore['OUTPUT_JOHN_FILE'], "ab") do |fd|
                fd.write("#{rhost} #{username}:$rakp$#{sha1_salt}$#{sha1_hash}\n")
                fd.flush
        Severity: Minor
        Found in modules/auxiliary/scanner/ipmi/ipmi_dumphashes.rb and 1 other location - About 25 mins to fix
        modules/auxiliary/scanner/ipmi/ipmi_dumphashes.rb on lines 269..272

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 30.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            if datastore['OUTPUT_HASHCAT_FILE']
              ::File.open(datastore['OUTPUT_HASHCAT_FILE'], "ab") do |fd|
                fd.write("#{rhost} #{username}:#{sha1_salt}:#{sha1_hash}\n")
                fd.flush
        Severity: Minor
        Found in modules/auxiliary/scanner/ipmi/ipmi_dumphashes.rb and 1 other location - About 25 mins to fix
        modules/auxiliary/scanner/ipmi/ipmi_dumphashes.rb on lines 276..279

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 30.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status