Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/auxiliary/scanner/msf/msf_web_login.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Method do_login has 64 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def do_login(user='msf', pass='msf')
    vprint_status(" - Trying username:'#{user}' with password:'#{pass}'")
    begin
      res = send_request_cgi({
        'uri'     => datastore['URILOGIN'],
Severity: Major
Found in modules/auxiliary/scanner/msf/msf_web_login.rb - About 2 hrs to fix

    Method do_login has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

      def do_login(user='msf', pass='msf')
    vprint_status(" - Trying username:'#{user}' with password:'#{pass}'")
    begin
      res = send_request_cgi({
        'uri'     => datastore['URILOGIN'],
    Severity: Minor
    Found in modules/auxiliary/scanner/msf/msf_web_login.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

            return :next_user
    Severity: Major
    Found in modules/auxiliary/scanner/msf/msf_web_login.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

            return :abort
      Severity: Major
      Found in modules/auxiliary/scanner/msf/msf_web_login.rb - About 30 mins to fix

        Similar blocks of code found in 25 locations. Consider refactoring.
        Open

          def report_cred(opts)
    service_data = {
      address: opts[:ip],
      port: opts[:port],
      service_name: opts[:service_name],
        Severity: Major
        Found in modules/auxiliary/scanner/msf/msf_web_login.rb and 24 other locations - About 1 hr to fix
        lib/msf/core/auxiliary/cnpilot.rb on lines 15..39
        lib/msf/core/auxiliary/epmp.rb on lines 15..39
        modules/auxiliary/admin/scada/modicon_password_recovery.rb on lines 91..115
        modules/auxiliary/scanner/http/binom3_login_config_pass_dump.rb on lines 55..79
        modules/auxiliary/scanner/http/gavazzi_em_login_loot.rb on lines 86..110
        modules/auxiliary/scanner/http/meteocontrol_weblog_extractadmin.rb on lines 107..131
        modules/auxiliary/scanner/http/oracle_ilom_login.rb on lines 70..94
        modules/auxiliary/scanner/http/pocketpad_login.rb on lines 65..89
        modules/auxiliary/scanner/http/rfcode_reader_enum.rb on lines 144..168
        modules/auxiliary/scanner/http/sap_businessobjects_user_brute_web.rb on lines 44..68
        modules/auxiliary/scanner/http/sentry_cdu_enum.rb on lines 70..94
        modules/auxiliary/scanner/http/sevone_enum.rb on lines 66..90
        modules/auxiliary/scanner/http/typo3_bruteforce.rb on lines 39..63
        modules/auxiliary/scanner/lotus/lotus_domino_login.rb on lines 31..55
        modules/auxiliary/scanner/misc/oki_scanner.rb on lines 38..62
        modules/auxiliary/scanner/mongodb/mongodb_login.rb on lines 132..156
        modules/auxiliary/scanner/msf/msf_rpc_login.rb on lines 55..79
        modules/auxiliary/scanner/nessus/nessus_ntp_login.rb on lines 59..83
        modules/auxiliary/scanner/nexpose/nexpose_api_login.rb on lines 58..82
        modules/auxiliary/scanner/nntp/nntp_login.rb on lines 167..185
        modules/auxiliary/scanner/openvas/openvas_omp_login.rb on lines 56..80
        modules/auxiliary/scanner/openvas/openvas_otp_login.rb on lines 56..80
        modules/auxiliary/scanner/sap/sap_soap_rfc_brute_login.rb on lines 103..127
        modules/auxiliary/scanner/sap/sap_web_gui_brute_login.rb on lines 107..131

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 60.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            begin
      res = send_request_cgi({
        'uri'     => datastore['URILOGIN'],
        'method'  => 'GET'
        }, 25)
        Severity: Minor
        Found in modules/auxiliary/scanner/msf/msf_web_login.rb and 1 other location - About 30 mins to fix
        modules/auxiliary/scanner/nessus/nessus_xmlrpc_login.rb on lines 33..42

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 32.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status