Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/auxiliary/scanner/msmq/cve_2023_21554_queuejumper.rb

Summary

Maintainability
C
1 day
Test Coverage

Method run_host has 144 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def run_host(ip)
    base_header = BaseHeader.new

    # Version number is always 0x10
    base_header.version_number = 16
Severity: Major
Found in modules/auxiliary/scanner/msmq/cve_2023_21554_queuejumper.rb - About 5 hrs to fix

    File cve_2023_21554_queuejumper.rb has 257 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require 'bindata'

class MetasploitModule < Msf::Auxiliary
  include Msf::Exploit::Remote::Tcp
  include Msf::Auxiliary::Scanner
    Severity: Minor
    Found in modules/auxiliary/scanner/msmq/cve_2023_21554_queuejumper.rb - About 2 hrs to fix

      Method initialize has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'CVE-2023-21554 - QueueJumper - MSMQ RCE Check',
      Severity: Minor
      Found in modules/auxiliary/scanner/msmq/cve_2023_21554_queuejumper.rb - About 1 hr to fix

        Method run_host has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

          def run_host(ip)
    base_header = BaseHeader.new

    # Version number is always 0x10
    base_header.version_number = 16
        Severity: Minor
        Found in modules/auxiliary/scanner/msmq/cve_2023_21554_queuejumper.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status