Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/auxiliary/scanner/mssql/mssql_schemadump.rb

Summary

Maintainability
C
1 day
Test Coverage

Method get_mssql_schema has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
Open

  def get_mssql_schema
    mssql_db_names = get_db_names()
    mssql_schema=[]
    unless mssql_db_names.nil?
      mssql_db_names.each do |dbname|
Severity: Minor
Found in modules/auxiliary/scanner/mssql/mssql_schemadump.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run_host has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def run_host(ip)
    if session
      set_mssql_session(session.client)
    else
      unless mssql_login_datastore
Severity: Minor
Found in modules/auxiliary/scanner/mssql/mssql_schemadump.rb - About 1 hr to fix

    Method get_mssql_schema has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def get_mssql_schema
    mssql_db_names = get_db_names()
    mssql_schema=[]
    unless mssql_db_names.nil?
      mssql_db_names.each do |dbname|
    Severity: Minor
    Found in modules/auxiliary/scanner/mssql/mssql_schemadump.rb - About 1 hr to fix

      Method run_host has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

        def run_host(ip)
    if session
      set_mssql_session(session.client)
    else
      unless mssql_login_datastore
      Severity: Minor
      Found in modules/auxiliary/scanner/mssql/mssql_schemadump.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status