Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/auxiliary/scanner/mysql/mysql_authbypass_hashdump.rb

Summary

Maintainability
C
1 day
Test Coverage

Method run_host has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
Open

  def run_host(ip)

    # Keep track of results (successful connections)
    results = []
Severity: Minor
Found in modules/auxiliary/scanner/mysql/mysql_authbypass_hashdump.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run_host has 70 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def run_host(ip)

    # Keep track of results (successful connections)
    results = []
Severity: Major
Found in modules/auxiliary/scanner/mysql/mysql_authbypass_hashdump.rb - About 2 hrs to fix

    Method initialize has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize
    super(
      'Name'           => 'MySQL Authentication Bypass Password Dump',
      'Description'    => %Q{
        This module exploits a password bypass vulnerability in MySQL in order
    Severity: Minor
    Found in modules/auxiliary/scanner/mysql/mysql_authbypass_hashdump.rb - About 1 hr to fix

      Method dump_hashes has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

        def dump_hashes(host, port)

    # Grabs the username and password hashes and stores them as loot
    res = mysql_query("SELECT user,password from mysql.user")
    if res.nil?
      Severity: Minor
      Found in modules/auxiliary/scanner/mysql/mysql_authbypass_hashdump.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method dump_hashes has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def dump_hashes(host, port)

    # Grabs the username and password hashes and stores them as loot
    res = mysql_query("SELECT user,password from mysql.user")
    if res.nil?
      Severity: Minor
      Found in modules/auxiliary/scanner/mysql/mysql_authbypass_hashdump.rb - About 1 hr to fix

        There are no issues that match your filters.

        Category
        Status