Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/auxiliary/scanner/mysql/mysql_schemadump.rb

Summary

Maintainability
C
1 day
Test Coverage

Method get_schema has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
Open

  def get_schema
    mysql_schema=[]
    res = mysql_query("show databases")
    if res.size > 0
      res.each do |row|
Severity: Minor
Found in modules/auxiliary/scanner/mysql/mysql_schemadump.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method get_schema has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def get_schema
    mysql_schema=[]
    res = mysql_query("show databases")
    if res.size > 0
      res.each do |row|
Severity: Minor
Found in modules/auxiliary/scanner/mysql/mysql_schemadump.rb - About 1 hr to fix

    Method run_host has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def run_host(ip)
    # If we have a session make use of it
    if session
      print_status("Using existing session #{session.sid}")
      self.mysql_conn = session.client
    Severity: Minor
    Found in modules/auxiliary/scanner/mysql/mysql_schemadump.rb - About 1 hr to fix

      Method get_tbl_names has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

        def get_tbl_names(dbname)

    tables=[]
    res = mysql_query("SHOW tables from #{dbname}")
    if res.size > 0
      Severity: Minor
      Found in modules/auxiliary/scanner/mysql/mysql_schemadump.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method get_columns has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

        def get_columns(db_name,tbl_name)
    tables=[]
    res = mysql_query("desc #{db_name}.#{tbl_name}")
    if res.size > 0
      res.each do |row|
      Severity: Minor
      Found in modules/auxiliary/scanner/mysql/mysql_schemadump.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status