Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/auxiliary/scanner/ntp/ntp_monlist.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Method scanner_postscan has 63 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def scanner_postscan(batch)
    @results.keys.each do |k|
      response_map = { @probe => @results[k][:messages] }
      peer = "#{k}:#{rport}"
Severity: Major
Found in modules/auxiliary/scanner/ntp/ntp_monlist.rb - About 2 hrs to fix

    Method scanner_postscan has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

      def scanner_postscan(batch)
    @results.keys.each do |k|
      response_map = { @probe => @results[k][:messages] }
      peer = "#{k}:#{rport}"
    Severity: Minor
    Found in modules/auxiliary/scanner/ntp/ntp_monlist.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method initialize has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize
    super(
      'Name'        => 'NTP Monitor List Scanner',
      'Description' => %q{
        This module identifies NTP servers which permit "monlist" queries and
    Severity: Minor
    Found in modules/auxiliary/scanner/ntp/ntp_monlist.rb - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status