Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/auxiliary/scanner/oracle/oracle_hashdump.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Method run_host has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

  def run_host(ip)
    return if not check_dependencies

    # Checks for Version of Oracle. Behavior varies with oracle version.
    # 12c uses SHA-512 (explained in more detail in report_hashes() below)
Severity: Minor
Found in modules/auxiliary/scanner/oracle/oracle_hashdump.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run_host has 67 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def run_host(ip)
    return if not check_dependencies

    # Checks for Version of Oracle. Behavior varies with oracle version.
    # 12c uses SHA-512 (explained in more detail in report_hashes() below)
Severity: Major
Found in modules/auxiliary/scanner/oracle/oracle_hashdump.rb - About 2 hrs to fix

    Method report_hashes has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def report_hashes(table, ver, ip, service)

    # Before module jtr_oracle_fast cracks these hashes, they are converted (based on jtr_format)
    # to a format that John The Ripper can handle. This format is stored here.
    case ver
    Severity: Minor
    Found in modules/auxiliary/scanner/oracle/oracle_hashdump.rb - About 1 hr to fix

      Avoid too many return statements within this method.
      Open

            return
      Severity: Major
      Found in modules/auxiliary/scanner/oracle/oracle_hashdump.rb - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status