Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/auxiliary/scanner/rdp/cve_2019_0708_bluekeep.rb

Summary

Maintainability
C
1 day
Test Coverage

Method check_for_patch has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

  def check_for_patch
    begin
      6.times do
        _res = rdp_recv
      end
Severity: Minor
Found in modules/auxiliary/scanner/rdp/cve_2019_0708_bluekeep.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method check_for_patch has 50 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def check_for_patch
    begin
      6.times do
        _res = rdp_recv
      end
Severity: Minor
Found in modules/auxiliary/scanner/rdp/cve_2019_0708_bluekeep.rb - About 2 hrs to fix

    Method initialize has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize(info = {})
    super(
      update_info(
        info,
        'Name' => 'CVE-2019-0708 BlueKeep Microsoft Remote Desktop RCE Check',
    Severity: Minor
    Found in modules/auxiliary/scanner/rdp/cve_2019_0708_bluekeep.rb - About 1 hr to fix

      Method check_rdp_vuln has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

        def check_rdp_vuln
    # check if rdp is open
    is_rdp, version_info = rdp_fingerprint
    unless is_rdp
      vprint_error('Could not connect to RDP service.')
      Severity: Minor
      Found in modules/auxiliary/scanner/rdp/cve_2019_0708_bluekeep.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method check_rdp_vuln has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def check_rdp_vuln
    # check if rdp is open
    is_rdp, version_info = rdp_fingerprint
    unless is_rdp
      vprint_error('Could not connect to RDP service.')
      Severity: Minor
      Found in modules/auxiliary/scanner/rdp/cve_2019_0708_bluekeep.rb - About 1 hr to fix

        Method check_host has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def check_host(_ip)
    # The check command will call this method instead of run_host
    status = Exploit::CheckCode::Unknown

    begin
        Severity: Minor
        Found in modules/auxiliary/scanner/rdp/cve_2019_0708_bluekeep.rb - About 1 hr to fix

          There are no issues that match your filters.

          Category
          Status