Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/auxiliary/scanner/rservices/rexec_login.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method do_login has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def do_login(user, pass, sfd, stderr_port)
    vprint_status("#{target_host}:#{rport} - Attempting rexec with username:password '#{user}':'#{pass}'")

    cmd = datastore['CMD']
    cmd ||= 'sh -i 2>&1'
Severity: Minor
Found in modules/auxiliary/scanner/rservices/rexec_login.rb - About 1 hr to fix

    Method start_rexec_session has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      def start_rexec_session(host, port, user, pass, proof, stderr_sock)
    Severity: Minor
    Found in modules/auxiliary/scanner/rservices/rexec_login.rb - About 45 mins to fix

      Method do_login has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def do_login(user, pass, sfd, stderr_port)
    vprint_status("#{target_host}:#{rport} - Attempting rexec with username:password '#{user}':'#{pass}'")

    cmd = datastore['CMD']
    cmd ||= 'sh -i 2>&1'
      Severity: Minor
      Found in modules/auxiliary/scanner/rservices/rexec_login.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method listen_on_random_port has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def listen_on_random_port(specific_port = 0)
    stderr_port = nil
    if specific_port > 0
      stderr_port = specific_port
      sd = listen_on_port(stderr_port)
      Severity: Minor
      Found in modules/auxiliary/scanner/rservices/rexec_login.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status