Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/auxiliary/scanner/rservices/rlogin_login.rb

Summary

Maintainability
D
2 days
Test Coverage

Method do_login has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
Open

  def do_login(user, pass, luser, status = nil)
    # Reset our accumulators for interacting with /bin/login
    @recvd = ''
    @trace = ''
Severity: Minor
Found in modules/auxiliary/scanner/rservices/rlogin_login.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method each_user_fromuser_pass has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
Open

  def each_user_fromuser_pass(&block)
    # Class variables to track credential use (for threading)
    @@credentials_tried = {}
    @@credentials_skipped = {}
Severity: Minor
Found in modules/auxiliary/scanner/rservices/rlogin_login.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method do_login has 60 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def do_login(user, pass, luser, status = nil)
    # Reset our accumulators for interacting with /bin/login
    @recvd = ''
    @trace = ''
Severity: Major
Found in modules/auxiliary/scanner/rservices/rlogin_login.rb - About 2 hrs to fix

    Method each_user_fromuser_pass has 59 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def each_user_fromuser_pass(&block)
    # Class variables to track credential use (for threading)
    @@credentials_tried = {}
    @@credentials_skipped = {}
    Severity: Major
    Found in modules/auxiliary/scanner/rservices/rlogin_login.rb - About 2 hrs to fix

      Method try_user_pass has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def try_user_pass(user, luser, pass, status = nil)
    luser ||= 'root'

    vprint_status "#{rhost}:#{rport} rlogin - Attempting: '#{user}':#{pass.inspect} from '#{luser}'"
      Severity: Minor
      Found in modules/auxiliary/scanner/rservices/rlogin_login.rb - About 1 hr to fix

        Method start_rlogin_session has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def start_rlogin_session(host, port, user, luser, pass, proof)
    service_data = {
      address: host,
      port: port,
      service_name: 'rlogin',
        Severity: Minor
        Found in modules/auxiliary/scanner/rservices/rlogin_login.rb - About 1 hr to fix

          Method try_user_pass has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

            def try_user_pass(user, luser, pass, status = nil)
    luser ||= 'root'

    vprint_status "#{rhost}:#{rport} rlogin - Attempting: '#{user}':#{pass.inspect} from '#{luser}'"
          Severity: Minor
          Found in modules/auxiliary/scanner/rservices/rlogin_login.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method start_rlogin_session has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

            def start_rlogin_session(host, port, user, luser, pass, proof)
          Severity: Minor
          Found in modules/auxiliary/scanner/rservices/rlogin_login.rb - About 45 mins to fix

            Avoid too many return statements within this method.
            Open

                  return :fail
            Severity: Major
            Found in modules/auxiliary/scanner/rservices/rlogin_login.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                    return :success
              Severity: Major
              Found in modules/auxiliary/scanner/rservices/rlogin_login.rb - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                        return :no_pass_prompt
                Severity: Major
                Found in modules/auxiliary/scanner/rservices/rlogin_login.rb - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                          return :succeeded # intentionally not :success
                  Severity: Major
                  Found in modules/auxiliary/scanner/rservices/rlogin_login.rb - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                            return :fail
                    Severity: Major
                    Found in modules/auxiliary/scanner/rservices/rlogin_login.rb - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                              return :success
                      Severity: Major
                      Found in modules/auxiliary/scanner/rservices/rlogin_login.rb - About 30 mins to fix

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                              service_data.merge!(:pass => pass)
      credential_data.merge!('PASSWORD' => pass)
      info = "RLOGIN #{user}:#{pass} (#{host}:#{port})"
                        Severity: Minor
                        Found in modules/auxiliary/scanner/rservices/rlogin_login.rb and 1 other location - About 15 mins to fix
                        modules/auxiliary/scanner/rservices/rlogin_login.rb on lines 324..326

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 25.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                              service_data.merge!(:luser => luser)
      credential_data.merge!('FROMUSER'=> luser)
      info = "RLOGIN #{user} from #{luser} (#{host}:#{port})"
                        Severity: Minor
                        Found in modules/auxiliary/scanner/rservices/rlogin_login.rb and 1 other location - About 15 mins to fix
                        modules/auxiliary/scanner/rservices/rlogin_login.rb on lines 320..322

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 25.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        There are no issues that match your filters.

                        Category
                        Status