Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/auxiliary/scanner/rsync/modules_list.rb

Summary

Maintainability
C
1 day
Test Coverage

Method run_host has 69 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def run_host(ip)
    begin
      connect
      version, motd = rsync_negotiate
      unless version
Severity: Major
Found in modules/auxiliary/scanner/rsync/modules_list.rb - About 2 hrs to fix

    Method run_host has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

      def run_host(ip)
    begin
      connect
      version, motd = rsync_negotiate
      unless version
    Severity: Minor
    Found in modules/auxiliary/scanner/rsync/modules_list.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method initialize has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize
    super(
      'Name'        => 'List Rsync Modules',
      'Description' => %q(
        An rsync module is essentially a directory share.  These modules can
    Severity: Minor
    Found in modules/auxiliary/scanner/rsync/modules_list.rb - About 1 hr to fix

      Method rsync_negotiate has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        def rsync_negotiate
    # rsync is promiscuous and will send the negotiation and motd
    # upon connecting.  abort if we get nothing
    return unless (greeting = sock.get_once(-1, read_timeout))
      Severity: Minor
      Found in modules/auxiliary/scanner/rsync/modules_list.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method rsync_list has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def rsync_list
    sock.puts("#list\n")

    modules_metadata = []
    # the module listing is the module name and comment separated by a tab, each module
      Severity: Minor
      Found in modules/auxiliary/scanner/rsync/modules_list.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method get_rsync_auth_status has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def get_rsync_auth_status(rmodule)
    sock.puts("#{rmodule}\n")
    res = sock.get_once(-1, read_timeout)
    if res
      res.strip!
      Severity: Minor
      Found in modules/auxiliary/scanner/rsync/modules_list.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status