Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/auxiliary/scanner/sap/sap_mgmt_con_getprocessparameter.rb

Summary

Maintainability
C
1 day
Test Coverage

Method getprocparam has a Cognitive Complexity of 49 (exceeds 5 allowed). Consider refactoring.
Open

  def getprocparam(rhost)
    print_status("[SAP] Connecting to SAP Management Console SOAP Interface on #{rhost}:#{rport}")
    success = false
    soapenv = 'http://schemas.xmlsoap.org/soap/envelope/'
    xsi = 'http://www.w3.org/2001/XMLSchema-instance'
Severity: Minor
Found in modules/auxiliary/scanner/sap/sap_mgmt_con_getprocessparameter.rb - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getprocparam has 105 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def getprocparam(rhost)
    print_status("[SAP] Connecting to SAP Management Console SOAP Interface on #{rhost}:#{rport}")
    success = false
    soapenv = 'http://schemas.xmlsoap.org/soap/envelope/'
    xsi = 'http://www.w3.org/2001/XMLSchema-instance'
Severity: Major
Found in modules/auxiliary/scanner/sap/sap_mgmt_con_getprocessparameter.rb - About 4 hrs to fix

    Avoid too many return statements within this method.
    Open

          return
    Severity: Major
    Found in modules/auxiliary/scanner/sap/sap_mgmt_con_getprocessparameter.rb - About 30 mins to fix

      There are no issues that match your filters.

      Category
      Status