Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/auxiliary/scanner/sap/sap_soap_rfc_sxpg_command_exec.rb

Summary

Maintainability
C
1 day
Test Coverage

Method run_host has 67 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def run_host(ip)
    os = datastore['OS']
    data = '<?xml version="1.0" encoding="utf-8" ?>'
    data << '<env:Envelope xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:env="http://schemas.xmlsoap.org/soap/envelope/" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">'
    data << '<env:Body>'
Severity: Major
Found in modules/auxiliary/scanner/sap/sap_soap_rfc_sxpg_command_exec.rb - About 2 hrs to fix

    Method run_host has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

      def run_host(ip)
    os = datastore['OS']
    data = '<?xml version="1.0" encoding="utf-8" ?>'
    data << '<env:Envelope xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:env="http://schemas.xmlsoap.org/soap/envelope/" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">'
    data << '<env:Body>'
    Severity: Minor
    Found in modules/auxiliary/scanner/sap/sap_soap_rfc_sxpg_command_exec.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method initialize has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize
    super(
      'Name' => 'SAP SOAP RFC SXPG_COMMAND_EXECUTE',
      'Description' => %q{
          This module makes use of the SXPG_COMMAND_EXECUTE Remote Function Call, through
    Severity: Minor
    Found in modules/auxiliary/scanner/sap/sap_soap_rfc_sxpg_command_exec.rb - About 1 hr to fix

      Avoid too many return statements within this method.
      Open

            return
      Severity: Major
      Found in modules/auxiliary/scanner/sap/sap_soap_rfc_sxpg_command_exec.rb - About 30 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          def initialize
    super(
      'Name' => 'SAP SOAP RFC SXPG_COMMAND_EXECUTE',
      'Description' => %q{
          This module makes use of the SXPG_COMMAND_EXECUTE Remote Function Call, through
        Severity: Major
        Found in modules/auxiliary/scanner/sap/sap_soap_rfc_sxpg_command_exec.rb and 1 other location - About 1 hr to fix
        modules/auxiliary/scanner/sap/sap_soap_rfc_sxpg_call_system_exec.rb on lines 22..50

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 72.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 5 locations. Consider refactoring.
        Open

              res = send_request_cgi({
        'uri' => '/sap/bc/soap/rfc',
        'method' => 'POST',
        'data' => data,
        'cookie' => "sap-usercontext=sap-language=EN&sap-client=#{datastore['CLIENT']}",
        Severity: Major
        Found in modules/auxiliary/scanner/sap/sap_soap_rfc_sxpg_command_exec.rb and 4 other locations - About 45 mins to fix
        modules/auxiliary/scanner/sap/sap_soap_rfc_susr_rfc_user_interface.rb on lines 70..83
        modules/auxiliary/scanner/sap/sap_soap_rfc_sxpg_call_system_exec.rb on lines 72..85
        modules/auxiliary/scanner/sap/sap_soap_rfc_system_info.rb on lines 88..101
        modules/auxiliary/scanner/sap/sap_soap_th_saprel_disclosure.rb on lines 63..76

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 39.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                error = res.body.scan(%r{<faultstring>(.*?)</faultstring>}).flatten
        0.upto(error.length-1) do |i|
          print_error("[SAP] #{ip}:#{rport} - error #{error[i]}")
        end
        return
        Severity: Minor
        Found in modules/auxiliary/scanner/sap/sap_soap_rfc_sxpg_command_exec.rb and 1 other location - About 20 mins to fix
        modules/auxiliary/scanner/sap/sap_soap_rfc_dbmcli_sxpg_command_exec.rb on lines 114..119

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 28.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status