Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/auxiliary/scanner/sip/sipdroid_ext_enum.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Method run has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

  def run()
    strtport = datastore['STRTPORT']
    fnlport = datastore['FNLPORT']

    print_status("Trying target #{datastore['RHOST']}...")
Severity: Minor
Found in modules/auxiliary/scanner/sip/sipdroid_ext_enum.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def run()
    strtport = datastore['STRTPORT']
    fnlport = datastore['FNLPORT']

    print_status("Trying target #{datastore['RHOST']}...")
Severity: Minor
Found in modules/auxiliary/scanner/sip/sipdroid_ext_enum.rb - About 1 hr to fix

    Method create_probe has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def create_probe(ip, meth, branch, tag, callid)
    suser = Rex::Text.rand_text_alphanumeric(rand(8)+1)
    shost = Rex::Socket.source_address(ip)
    src      = "#{shost}:5060"
    Severity: Minor
    Found in modules/auxiliary/scanner/sip/sipdroid_ext_enum.rb - About 1 hr to fix

      Avoid deeply nested control flow statements.
      Open

                    if not origin.nil?
                print_good(/\w+\@[\w+\.]+/.match(origin.to_s).to_s)
              else
                print_status("Ringing message received but no user/gateway sent...")
              end
      Severity: Major
      Found in modules/auxiliary/scanner/sip/sipdroid_ext_enum.rb - About 45 mins to fix

        Method create_probe has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

          def create_probe(ip, meth, branch, tag, callid)
        Severity: Minor
        Found in modules/auxiliary/scanner/sip/sipdroid_ext_enum.rb - About 35 mins to fix

          There are no issues that match your filters.

          Category
          Status