Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/auxiliary/scanner/smb/impacket/secretsdump.py

Summary

Maintainability
C
1 day
Test Coverage

Function dump has a Cognitive Complexity of 55 (exceeds 5 allowed). Consider refactoring.
Open

    def dump(self):
        try:
            if self.__remoteName.upper() == 'LOCAL' and self.__username == '':
                self.__isRemote = False
                self.__useVSSMethod = True
Severity: Minor
Found in modules/auxiliary/scanner/smb/impacket/secretsdump.py - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function __init__ has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def __init__(self, remoteName, username='', password='', domain='', outputFile=None, execMethod='smbexec'):
        self.__useVSSMethod = False
        self.__remoteName = remoteName
        self.__remoteHost = remoteName
        self.__username = username
Severity: Minor
Found in modules/auxiliary/scanner/smb/impacket/secretsdump.py - About 1 hr to fix

    Function __init__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def __init__(self, remoteName, username='', password='', domain='', outputFile=None, execMethod='smbexec'):
    Severity: Minor
    Found in modules/auxiliary/scanner/smb/impacket/secretsdump.py - About 45 mins to fix

      There are no issues that match your filters.

      Category
      Status