Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/auxiliary/scanner/smb/psexec_loggedin_users.rb

Summary

Maintainability
C
1 day
Test Coverage

Method check_hku_entry has a Cognitive Complexity of 44 (exceeds 5 allowed). Consider refactoring.
Open

  def check_hku_entry(key, ip, smbshare, cmd, text, bat)
    begin
      key = key.split("HKEY_USERS\\")[1].chomp
      command = "#{cmd} /C echo reg.exe QUERY \"HKU\\#{key}\\Volatile Environment\" ^> %SYSTEMDRIVE%#{text} > #{bat} & #{cmd} /C start cmd.exe /C #{bat}"
      out = psexec(command)
Severity: Minor
Found in modules/auxiliary/scanner/smb/psexec_loggedin_users.rb - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method check_hku_entry has 54 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def check_hku_entry(key, ip, smbshare, cmd, text, bat)
    begin
      key = key.split("HKEY_USERS\\")[1].chomp
      command = "#{cmd} /C echo reg.exe QUERY \"HKU\\#{key}\\Volatile Environment\" ^> %SYSTEMDRIVE%#{text} > #{bat} & #{cmd} /C start cmd.exe /C #{bat}"
      out = psexec(command)
Severity: Major
Found in modules/auxiliary/scanner/smb/psexec_loggedin_users.rb - About 2 hrs to fix

    Method check_hku_entry has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      def check_hku_entry(key, ip, smbshare, cmd, text, bat)
    Severity: Minor
    Found in modules/auxiliary/scanner/smb/psexec_loggedin_users.rb - About 45 mins to fix

      Method query_session has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        def query_session(smbshare, ip, cmd, text, bat)
      Severity: Minor
      Found in modules/auxiliary/scanner/smb/psexec_loggedin_users.rb - About 35 mins to fix

        Method get_hku has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

          def get_hku(ip, smbshare, cmd, text, bat)
        Severity: Minor
        Found in modules/auxiliary/scanner/smb/psexec_loggedin_users.rb - About 35 mins to fix

          Method query_session has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            def query_session(smbshare, ip, cmd, text, bat)
    begin
      command = "#{cmd} /C echo query session ^> %SYSTEMDRIVE%#{text} > #{bat} & #{cmd} /C start cmd.exe /C #{bat}"
      out = psexec(command)
      userline = ""
          Severity: Minor
          Found in modules/auxiliary/scanner/smb/psexec_loggedin_users.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                simple.connect("\\\\#{ip}\\#{smbshare}")
      outfile = simple.open(file, 'ro')
      output = outfile.read
      outfile.close
      simple.disconnect("\\\\#{ip}\\#{smbshare}")
          Severity: Minor
          Found in modules/auxiliary/scanner/smb/psexec_loggedin_users.rb and 1 other location - About 25 mins to fix
          lib/msf/core/exploit/remote/smb/client/psexec.rb on lines 74..79

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 29.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status