Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/auxiliary/scanner/smb/smb_lookupsid.rb

Summary

Maintainability
D
1 day
Test Coverage

Method run_host has a Cognitive Complexity of 46 (exceeds 5 allowed). Consider refactoring.
Open

  def run_host(ip)
    ports = [139, 445]

    if session
      print_status("Using existing session #{session.sid}")
Severity: Minor
Found in modules/auxiliary/scanner/smb/smb_lookupsid.rb - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run_host has 127 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def run_host(ip)
    ports = [139, 445]

    if session
      print_status("Using existing session #{session.sid}")
Severity: Major
Found in modules/auxiliary/scanner/smb/smb_lookupsid.rb - About 5 hrs to fix

    Method smb_find_dcerpc_pipe has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

      def smb_find_dcerpc_pipe(uuid, vers, pipes)
    found_pipe   = nil
    found_handle = nil
    pipes.each do |pipe_name|
      connected = session ? true : false
    Severity: Minor
    Found in modules/auxiliary/scanner/smb/smb_lookupsid.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method initialize has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize
    super(
      'Name'        => 'SMB SID User Enumeration (LookupSid)',
      'Description' => 'Determine what users exist via brute force SID lookups.
        This module can enumerate both local and domain accounts by setting
    Severity: Minor
    Found in modules/auxiliary/scanner/smb/smb_lookupsid.rb - About 1 hr to fix

      Identical blocks of code found in 3 locations. Consider refactoring.
      Open

          if session
      print_status("Using existing session #{session.sid}")
      client = session.client
      self.simple = ::Rex::Proto::SMB::SimpleClient.new(client.dispatcher.tcp_socket, client: client)
      ports = [simple.port]
      Severity: Minor
      Found in modules/auxiliary/scanner/smb/smb_lookupsid.rb and 2 other locations - About 35 mins to fix
      modules/auxiliary/scanner/smb/pipe_dcerpc_auditor.rb on lines 258..263
      modules/auxiliary/scanner/smb/smb_enumusers_domain.rb on lines 129..134

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 36.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status