Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/auxiliary/scanner/smtp/smtp_relay.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method run_host has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def run_host(ip)
    begin
      connect
      banner_sanitized = Rex::Text.to_hex_ascii(banner.to_s)
      print_good("SMTP #{banner_sanitized}")
Severity: Minor
Found in modules/auxiliary/scanner/smtp/smtp_relay.rb - About 1 hr to fix

    Method do_test_relay has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def do_test_relay(testnumber, mailfrom, mailto)
    begin
      connect

      res = raw_send_recv("EHLO X\r\n")
    Severity: Minor
    Found in modules/auxiliary/scanner/smtp/smtp_relay.rb - About 1 hr to fix

      Method do_test_relay has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        def do_test_relay(testnumber, mailfrom, mailto)
    begin
      connect

      res = raw_send_recv("EHLO X\r\n")
      Severity: Minor
      Found in modules/auxiliary/scanner/smtp/smtp_relay.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status